chore(deps): remove unused 'color' dependency #891
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
color
dependency, which I don't think we are using.Causes no obvious regressions when I run the docs locally.
I'm tagging reviewers that might have more context about why it was pulled in, based on my spelunking described below.
Why did I spend time on this?
I was going through dependabot PRs and saw #768, a major-version bump for the
color
package. I wanted to update it, but I like to know where things are used so I can smoke test them before I merge dependency updates. I didn't find anywhere thatcolor
was used.Why don't I think it is used anywhere?
I searched for
"color"
,'color'
,color(
, andcolor.
, and saw no significant results. I attempted to search for the whole wordcolor
but there were too many results to meaningfully identify its usage.These first two tell me that we never import or require this dependency (as in


import color from "color"
):These last two tell me that we never use the


color
API:I am not sure if there's any other way for docusaurus to magically make use of this dependency, but it appears to me it's not used.
When did it get pulled in?
As part of #99 - be warned that that is a very large release, and the github UI slows considerably while trying to navigate it.
More specifically, in this commit, titled "add version 0.25". Be warned that this also is a very large commit, and the github UI slows considerably while trying to navigate it.
I can't glean any information from that commit about why it was added. I'm tagging @urbanisierung and @akeller for a review because they might have been involved in that work, but I fully expect neither of them to remember a dependency added a year and a half ago.