Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): remove unused 'color' dependency #891

Merged
merged 1 commit into from
May 12, 2022

Conversation

pepopowitz
Copy link
Collaborator

@pepopowitz pepopowitz commented May 9, 2022

Removes the color dependency, which I don't think we are using.

Causes no obvious regressions when I run the docs locally.

I'm tagging reviewers that might have more context about why it was pulled in, based on my spelunking described below.

Why did I spend time on this?

I was going through dependabot PRs and saw #768, a major-version bump for the color package. I wanted to update it, but I like to know where things are used so I can smoke test them before I merge dependency updates. I didn't find anywhere that color was used.

Why don't I think it is used anywhere?

I searched for "color", 'color', color(, and color., and saw no significant results. I attempted to search for the whole word color but there were too many results to meaningfully identify its usage.

These first two tell me that we never import or require this dependency (as in import color from "color"):
image
image

These last two tell me that we never use the color API:
image
image

I am not sure if there's any other way for docusaurus to magically make use of this dependency, but it appears to me it's not used.

When did it get pulled in?

As part of #99 - be warned that that is a very large release, and the github UI slows considerably while trying to navigate it.

More specifically, in this commit, titled "add version 0.25". Be warned that this also is a very large commit, and the github UI slows considerably while trying to navigate it.

I can't glean any information from that commit about why it was added. I'm tagging @urbanisierung and @akeller for a review because they might have been involved in that work, but I fully expect neither of them to remember a dependency added a year and a half ago.

Copy link
Member

@berndruecker berndruecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I follow your reasoning and think we should go ahead and remove it (and just keep a close eye to what could probably break). I also haven't quickly found any reference to it. If it comes with docusaurus it should be a transitive dependency I guess.

@pepopowitz pepopowitz merged commit c2b9a1b into master May 12, 2022
@pepopowitz pepopowitz deleted the pepopowitz/remove-color branch May 12, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants