Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Documentation for starting standalone schema manager #5101
feat: Documentation for starting standalone schema manager #5101
Changes from 7 commits
8f35dc0
1472c61
0c08cee
4c8b223
def8773
4b1f930
d6c9bba
ec198b3
6a78531
21430f7
1760e61
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔧 I would omit the sentence
The schema manager solely creates all necessary Elasticsearch Indices
. I think it just leads to confusion (since it actually does more than this anyway), and gives unnecessary details. We can leave it at that the application creates the necessary schema for C8 to run afterwards without cluster privileges.🔧 Similarly, we use
elevated privileges
andcluster privileges
interchangeably, and I don;'t know if that's true? I would pick one, likelycluster level privileges
, and just stick to it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Do we need to specify the required permissions? Or is there an ES equivalent, i.e. saying
superuser
or something (is that a thing for ES?).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this configuration requires tasklist and operate to know the elasticsearchs url in the form of this example:
camunda.operate.elasticsearch.url: "http://camunda-elasticsearch:9200"
and
camunda.tasklist.elasticsearch.url: "http://camunda-elasticsearch:9200"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left this undefined on purpose, because I am only documenting the necessary changes additionally to the settings the customer already has. When left unset, in our example, all tools will use the default
http://localhost:9200
, however if customers have a running setup where they use different URLs, if I add this field here, this would possibly confuse themThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note that I removed these 3 params that were present in our test-config so that standard values are used:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note that I removed these 3 params that were present in our test-config so that standard values are used: