-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update docs after C7 config got removed from Optimize C8 #5089
base: main
Are you sure you want to change the base?
Conversation
👋 🤖 🤔 Hello, @abremard! Did you make your changes in all the right places? These files were changed only in optimize/. You might want to duplicate these changes in optimize_versioned_docs/version-3.14.0/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
…-configuration.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@RomanJRW This is low priority, I'm adding you as a reviewer because you've reviewed the config removal |
optimize/self-managed/optimize-deployment/configuration/system-configuration.md
Show resolved
Hide resolved
| plugin.engineRestFilter.basePackages | | Look in the given base package list for engine rest filter plugins. If empty, the REST calls are not influenced. | | ||
| plugin.decisionInputImport.basePackages | | Look in the given base package list for Decision input import adaption plugins. If empty, the import is not influenced. | | ||
| plugin.decisionOutputImport.basePackages | | Look in the given base package list for Decision output import adaption plugins. If empty, the import is not influenced. | | ||
| plugin.elasticsearchCustomHeader.basePackages | | Look in the given base package list for Elasticsearch custom header plugins. If empty, Elasticsearch requests are not influenced. | | ||
| serialization.engineDateFormat | yyyy-MM-dd'T'HH:mm:ss.SSSZ | Define a custom date format that should be used (should be the same as in the engine). | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this not also something that can be deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like ObjectMapperFactory::createEngineMapper which reads serialization.engineDateFormat
is still being called in several classes 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this just in test classes though? Probably this can be deleted along with the tests. I think this is a remnant of C7
Description
When should this change go live?
bug
orsupport
label)available & undocumented
label)hold
label)low prio
label)PR Checklist
/docs
directory (version 8.8)./versioned_docs/version-8.7/
directory (version 8.7)./versioned_docs
directory.@camunda/tech-writers
unless working with an embedded writer.