Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update docs after C7 config got removed from Optimize C8 #5089

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

abremard
Copy link

@abremard abremard commented Feb 26, 2025

Description

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support. (add bug or support label)
  • This is already available but undocumented and should be released within a week. (add available & undocumented label)
  • This is on a specific schedule and the assignee will coordinate a release with the DevEx team. (create draft PR and/or add hold label)
  • This is part of a scheduled alpha or minor. (add alpha or minor label)
  • There is no urgency with this change (add low prio label)

PR Checklist

  • My changes are for an upcoming minor release and:
    • are in the /docs directory (version 8.8).
    • are in the /versioned_docs/version-8.7/ directory (version 8.7).
  • My changes are for an already released minor and are in a /versioned_docs directory.

Copy link
Contributor

github-actions bot commented Feb 26, 2025

👋 🤖 🤔 Hello, @abremard! Did you make your changes in all the right places?

These files were changed only in optimize/. You might want to duplicate these changes in optimize_versioned_docs/version-3.14.0/.

  • optimize/self-managed/optimize-deployment/configuration/service-config.yaml
  • optimize/self-managed/optimize-deployment/configuration/system-configuration.md
These files were changed only in optimize/. You might want to duplicate these changes in optimize_versioned_docs/version-3.15.0/.
  • optimize/self-managed/optimize-deployment/configuration/service-config.yaml
  • optimize/self-managed/optimize-deployment/configuration/system-configuration.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@abremard abremard added the low prio There is no urgency with this change. label Feb 26, 2025
@abremard abremard requested a review from RomanJRW February 26, 2025 07:21
…-configuration.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@abremard
Copy link
Author

@RomanJRW This is low priority, I'm adding you as a reviewer because you've reviewed the config removal

RomanJRW
RomanJRW previously approved these changes Feb 26, 2025
| plugin.engineRestFilter.basePackages | | Look in the given base package list for engine rest filter plugins. If empty, the REST calls are not influenced. |
| plugin.decisionInputImport.basePackages | | Look in the given base package list for Decision input import adaption plugins. If empty, the import is not influenced. |
| plugin.decisionOutputImport.basePackages | | Look in the given base package list for Decision output import adaption plugins. If empty, the import is not influenced. |
| plugin.elasticsearchCustomHeader.basePackages | | Look in the given base package list for Elasticsearch custom header plugins. If empty, Elasticsearch requests are not influenced. |
| serialization.engineDateFormat | yyyy-MM-dd'T'HH:mm:ss.SSSZ | Define a custom date format that should be used (should be the same as in the engine). |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this not also something that can be deleted?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like ObjectMapperFactory::createEngineMapper which reads serialization.engineDateFormat is still being called in several classes 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this just in test classes though? Probably this can be deleted along with the tests. I think this is a remnant of C7

@RomanJRW RomanJRW requested a review from a team February 26, 2025 10:07
@akeller akeller added the component:optimize Issues related with Optimize project label Feb 26, 2025
@abremard abremard requested a review from RomanJRW February 28, 2025 01:12
@abremard abremard linked an issue Feb 28, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:optimize Issues related with Optimize project low prio There is no urgency with this change.
Projects
Status: 👀 In Review
Development

Successfully merging this pull request may close these issues.

Review Optimize system configuration page for C7 vs. C8 config
4 participants