Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: automatically add review comments to prettier infractions #2680

Merged
merged 9 commits into from
Oct 3, 2023
Merged

feat: automatically add review comments to prettier infractions #2680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b68b388
feat: define crossover link validation rules and enable them with vale
pepopowitz Oct 2, 2023
ac1f252
feat: run vale as a pull request check
pepopowitz Oct 2, 2023
f18b6ca
feat: add a linting rule for production links
pepopowitz Oct 2, 2023
79cd1b8
fix: swap order of prettier and vale, so that both of them run on eve…
pepopowitz Oct 3, 2023
bf79bf2
oops: remove prettier changes frmo this PR
pepopowitz Oct 3, 2023
38daeaa
docs: add descriptions to each of the vale rules
pepopowitz Oct 3, 2023
5b1f816
feat: automatically add review comments for prettier violations
pepopowitz Oct 3, 2023
c5176e1
cleanup: remove prettier step from build-docs workflow, because it's …
pepopowitz Oct 3, 2023
5809829
Merge branch 'main' into pepopowitz/1104-auto-review-prettier
pepopowitz Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/build-docs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ jobs:
node-version: 16
- name: Install Dependencies
run: npm ci
- name: Verify format
run: npm run format:check
- name: Build
run: npm run build
env:
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/check-format.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,9 @@ jobs:
with:
filter_mode: added
reporter: github-pr-review
- name: Verify format with Prettier
uses: EPMatt/reviewdog-action-prettier@v1
with:
github_token: ${{ secrets.github_token }}
reporter: github-pr-review
fail_on_error: true