Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(clients): edit go client assuming camunda cloud is default #132

Merged
merged 5 commits into from
Dec 22, 2020

Conversation

pihme
Copy link
Contributor

@pihme pihme commented Dec 21, 2020

Closes #89

Changes:

  • adds a new quick reference page for Go client
  • changes text to assume that Camunda Cloud is the default deployment

@pihme
Copy link
Contributor Author

pihme commented Dec 21, 2020

@miguelpires This review has some background automation. After you approve the review in GitHub you also need to add a /lgtm comment. Once you approve it, it will automatically be merged. So anything you want to change needs to happen before that.

Copy link
Contributor

@miguelpires miguelpires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, there's just some small readability issues in the code examples

@pihme pihme force-pushed the release_0_26_go_get_started_89 branch from bf20b3d to df31df6 Compare December 22, 2020 10:46
@pihme pihme requested a review from miguelpires December 22, 2020 10:48
@pihme pihme requested a review from miguelpires December 22, 2020 13:33
Copy link
Contributor

@miguelpires miguelpires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@camunda-cloud-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MiguelPires, pihme

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@miguelpires
Copy link
Contributor

/lgtm

@camunda-cloud-bot camunda-cloud-bot merged commit 4f43749 into release_0_26 Dec 22, 2020
@camunda-cloud-bot camunda-cloud-bot deleted the release_0_26_go_get_started_89 branch December 22, 2020 13:36
camunda-cloud-bot pushed a commit that referenced this pull request Jan 8, 2021
* update docs

* update getting started guide

* add version 0.25

* fix cloud-console-api-clients

* fix versioned cloud-console-api-clients

* add descriptions and update readme

* fix styling

* remove version banner (#103)

* Release 0 26 cloudconsole 73 (#102)

* update cloud console section

* fix references

* added screenshots

* minor improvements

* remove dup feedback screenshot

* fix indenting

Co-authored-by: Tim Schuppener <[email protected]>

* add modeler docs (#108)

* add cloud modeler docs

* add zeebe modeler docs

* remove involve humans from gsg

* chore(yaml-workflows): remove section (#111)

* chore(reference): move glossary to reference (#113)

* chore(zeebe): remove obsolete files (#121)

* Reduce menu bar items (#116)

* Most critical brand & color changes (#123)

* landing page branding compliance

* global CSS for IBM Plex & icemunda primary alert

* chore(reference): flatten reference structure

* chore(reference): move gRPC to reference

* chore(referenc): harmonize page titles

* chore(structure): change structure - part 1

* chore(zeebe): structural changes part 2

* chore(concepts): edit content

* chore(zeebe): edit technical concept and open source chapters

* Update Operate docs to 0.26.0 (#104)

* docs(operate): restructure pages

- Move introduction on top
- Move install & start to deployment guide
- Update sidebars

* docs(operate): update introduction page

- Add screenshots light/dark
- Add section how to get Operate
- Restructured page

Related with #82

* docs(operate): update userguide pages

- Update screenshots light/dark
- Change texts according to current feature set

Related with #82 , #83

* docs(operate): update incidents and variables page

Related with #82 #83

* docs(operate): include context-path; clean-up

Related with #82 #83

* docs(operate): update sidebar based on release_0_26

Related with #82 #83

* docs(operate): improved screenshots (crop) and use light mode

Related with #82

* docs(operate): fix broken links

Related with #82

* Tasklist documentation 0.26.0  (#127)

* docs(tasklist): add introduction and userguide

Related with #85 #86

* docs(tasklist): add install section

- Aligned with Operate deployment guide
- Add api-client page
- Clean up

Related with #86

docs(tasklist): add install section

- Aligned with Operate deployment guide
- Clean up

Related with #86

* docs(tasklist): add userguide overview

Related with #85

* docs(tasklist): Fix link to userguide

Related with #85

* docs(tasklist): add api client documentation

Related with #86 , #11

* docs(tasklist): add GraphQL API docs

Related to #11

* docs(tasklist): improved screenshots (crop)

Related with #85 and #86

* feat(reference): add reference for FEEL expressions

* disable dark mode (#126)

* feat(clients): edit intro page

* chore(clients): edit java client pages

* chore(clients): add pages for CLI client

* crop screenshots console (#129)

* find . -name "*png" -exec cropIf.sh {} 1028 833 67 0 0 0 \;

* find . -name "*png" -exec cropIf.sh {} 1032 835 68 2 2 2 \;

* find . -name "*png" -exec cropIf.sh {} 1028 690 68 0 0 0 \;

* find . -name "*png" -exec cropIf.sh {} 1028 690 68 0 0 0 \;

* find . -name "*png" -exec cropIf.sh {} 1376 835 68 2 2 2 \;

* find . -name "*png" -exec cropIf.sh {} 1032 977 68 2 2 2 \;

* skript to crop screenshots with decorations

* find . -not -path "./node_modules/*" -name "*png" -exec hacks/cropIf.sh {} 1028 833 68 0 0 0 \;

* fixed number of arguments

* chore(concepts): simplify variables and expressions concepts

* chore(clients): edit go client assuming camunda cloud is default (#132)

* chore(clients): edit go client assuming camunda cloud is default

* chore(go): Apply suggestions from code review

Co-authored-by: Miguel Pires <[email protected]>

* chore(clients): apply review suggestions throughout

* chore(go-client): fix indentation

* chore(go-client): Apply suggestions from code review

Co-authored-by: Miguel Pires <[email protected]>

Co-authored-by: Miguel Pires <[email protected]>

* feat(zeebe/deployment-guide): edit Zeebe deployment guide

* Overview pages for 0.26 (#128)

* removed samples

* missed a samples reference

* more samples references

* reference overview updates

* URL typo

* versioned directory changes

* fixed versioned paths, typos

* Camunda Cloud Intro page fixes (#134)

* introduction typo in URL

* stub intro page content

* including versioned dir changes

* file name typo

* style guide updates - typos, punctuation, consistency

Co-authored-by: Tim Schuppener <[email protected]>
Co-authored-by: Peter Ihme <[email protected]>
Co-authored-by: Amara Graham (Keller) <[email protected]>
Co-authored-by: Ralf Puchert <[email protected]>
Co-authored-by: Miguel Pires <[email protected]>
Co-authored-by: Amara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants