fix: use lint-staged correctly (to decrease commit time) #1226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Friday afternoon (my time) gift for @tmetzke:
What is the purpose of the change
Updates the pre-commit hook to run prettier against only files that have changed, for much faster commits.
How?
I was using lint-staged incorrectly! In a case of over-pursuing the DRY principle, I configured lint-staged to run
npm run format
, to avoid defining what "format" meant in two places.But the
format
script passes.
as the path to prettier, resulting in the entire codebase being formatted even for a one line change.lint-staged passes a glob for the committed files to the configured command...this change takes advantage of that, and now the hook will only format the files being committed.
Before this change
After this change
PR Checklist
/versioned_docs
directory, or they are not for an already released version./docs
directory, or they are not for future versions.