Support zeebe:TaskListener
#88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misiekhardcore
requested review from
philippfromme and
barmac
and removed request for
philippfromme
11 tasks
barmac
reviewed
Nov 14, 2024
barmac
reviewed
Nov 14, 2024
barmac
reviewed
Nov 14, 2024
|
I left a few minor comments, but other than that it's ready to merge 🚀 |
barmac
approved these changes
Nov 14, 2024
misiekhardcore
force-pushed
the
user-task-listener
branch
from
abad235 to
f6e688b
Compare
misiekhardcore
force-pushed
the
user-task-listener
branch
from
f6e688b to
0356acb
Compare
7 tasks
| const targetEl = elementRegistry.get('UserTask'); | ||
|
|
||
| // when | ||
| bpmnReplace.replaceElement(el, targetEl); |
There was a problem hiding this comment.
This is not how replace should be used. The target element must not be an existing element (cf. https://github.com/bpmn-io/bpmn-js/blob/develop/lib/features/replace/BpmnReplace.js#L141). We have to fix this whole spec.
There was a problem hiding this comment.
I missed that. Let's fix it.
There was a problem hiding this comment.
I'm working on a fix.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to camunda/camunda-modeler#4590
This PR adds support for
zeebe:TaskListenerIt allows
zeebe:TaskListeneronly inbpmn:UserTaskelements withzeebe:UserTaskextension and event types ofcompleteandassignment