Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Inclusive Gateway Rule #44

Merged
merged 2 commits into from
Sep 12, 2022
Merged

Add Inclusive Gateway Rule #44

merged 2 commits into from
Sep 12, 2022

Conversation

philippfromme
Copy link
Collaborator

  • add Camunda 8.1 configuration
  • allow inclusive gateways for Camunda Cloud 8.1 only
  • lint inclusive gateways

Related to camunda/camunda-modeler#3083

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Sep 12, 2022
@philippfromme philippfromme mentioned this pull request Sep 12, 2022
Merged
@philippfromme philippfromme marked this pull request as ready for review September 12, 2022 07:43
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Sep 12, 2022
barmac
barmac requested changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's improve it a bit, as the rule may be buggy when used with text annotations.

@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Sep 12, 2022
@philippfromme philippfromme mentioned this pull request Sep 12, 2022
Closed
13 tasks
@barmac barmac self-requested a review September 12, 2022 13:30
barmac
barmac approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@philippfromme philippfromme merged commit 3211273 into main Sep 12, 2022
@philippfromme philippfromme deleted the inclusive-gateway branch September 12, 2022 13:37
@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label Sep 12, 2022
@philippfromme philippfromme mentioned this pull request Oct 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barmac barmac barmac approved these changes

@pinussilvestrus pinussilvestrus Awaiting requested review from pinussilvestrus

Assignees

@philippfromme philippfromme

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippfromme @barmac