Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Linting of User Task Forms #148

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Fix Linting of User Task Forms #148

merged 2 commits into from
Nov 7, 2023

Conversation

philippfromme
Copy link
Collaborator

@philippfromme philippfromme commented Nov 7, 2023 •
edited
Loading

  • treats empty strings as errors (previously only undefined was treated as error)
  • changes supported version for formId to Camunda 8.4
  • updates integration tests

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Nov 7, 2023
nikku
nikku approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the swift follow-up 👏

@merge-me merge-me bot merged commit 4ebc355 into main Nov 7, 2023
@merge-me merge-me bot deleted the fix-forms branch November 7, 2023 10:34
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku approved these changes

@marstamm marstamm Awaiting requested review from marstamm

Assignees

@philippfromme philippfromme

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippfromme @nikku