Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(secrets): enable rule and report warn #137

Merged
merged 1 commit into from
Sep 22, 2023
Merged

feat(secrets): enable rule and report warn #137

merged 1 commit into from
Sep 22, 2023

Conversation

philippfromme
Copy link
Collaborator

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Sep 22, 2023
@philippfromme philippfromme mentioned this pull request Sep 22, 2023
Closed
@nikku
Copy link
Member

nikku commented Sep 22, 2023

Did we settle on info over warning? To date info is reserved for modeling only things.

@philippfromme
Copy link
Collaborator Author

Did we settle on info over warning? To date info is reserved for modeling only things.

Sorry, I misread your comment will change to warn.

@philippfromme philippfromme force-pushed the secrets-info branch 2 times, most recently from a1c336e to 2804f08 Compare September 22, 2023 10:15
@philippfromme philippfromme changed the title feat(secrets): enable rule and report info feat(secrets): enable rule and report warn Sep 22, 2023
@philippfromme
Copy link
Collaborator Author

@nikku Reported as warn now. Interaction with the properties panel will still be the same. No error but you can still focus the properties panel input.

@philippfromme philippfromme mentioned this pull request Sep 22, 2023
Merged
nikku
nikku reviewed Sep 22, 2023
View reviewed changes
test/config/configs.spec.js Outdated
@@ -135,6 +135,7 @@ describe('configs', function() {
'no-propagate-all-parent-variables' : [ 'error', { version: '8.0' } ],
'no-task-schedule': [ 'error', { version: '8.0' } ],
'no-zeebe-properties': [ 'error', { version: '8.0' } ],
'secrets': [ 'warn', { version: '8.0' } ],
Copy link
Member

@nikku nikku Sep 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I understand this will change for 8.3 and up only. Let's clarify this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is based on #116 (comment). Should we ask them again?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8.0 as an answer makes no sense to me, as 8.0 ships with an entirely different connector run-time (that does not know the new pattern yet).

Copy link
Collaborator Author

@philippfromme philippfromme Sep 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After clarification, the rule is only active for Camunda 8.3.

@merge-me merge-me bot merged commit a2a9bb3 into main Sep 22, 2023
@merge-me merge-me bot deleted the secrets-info branch September 22, 2023 13:33
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku approved these changes

@smbea smbea Awaiting requested review from smbea

@barmac barmac Awaiting requested review from barmac

Assignees

@philippfromme philippfromme

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippfromme @nikku