Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support converging inclusive gateway in 8.3 #111

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

barmac
Copy link
Contributor

@barmac barmac commented Jul 25, 2023

@barmac barmac requested review from a team, philippfromme and marstamm and removed request for a team July 25, 2023 11:52
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jul 25, 2023
index.js Outdated
@@ -50,7 +50,7 @@ const camundaCloud82Rules = withConfig({
}, { version: '8.2' });

const camundaCloud83Rules = withConfig({
...camundaCloud82Rules,
...withoutKeys(camundaCloud82Rules, [ 'inclusive-gateway' ]),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
...withoutKeys(camundaCloud82Rules, [ 'inclusive-gateway' ]),
......omit(camundaCloud82Rules, 'inclusive-gateway'),

We have a pattern for this already.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right 🍡

@barmac barmac force-pushed the support-converging-or-gateway branch from cfae72c to b6506b7 Compare July 25, 2023 12:28
@barmac barmac requested a review from philippfromme July 25, 2023 12:28
Copy link
Collaborator

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@merge-me merge-me bot merged commit 7ed5bb3 into main Jul 25, 2023
@merge-me merge-me bot deleted the support-converging-or-gateway branch July 25, 2023 12:40
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants