fix: ignore null properties

Related to camunda/camunda-modeler#3067
camunda · Aug 5, 2022 · 9d2dcb9 · 9d2dcb9
1 parent daab537
commit 9d2dcb9
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 3 deletions.
diff --git a/rules/utils/element.js b/rules/utils/element.js
@@ -1,6 +1,7 @@
 const {
   isArray,
   isDefined,
+  isNil,
   some
 } = require('min-dash');
 
@@ -147,7 +148,7 @@ module.exports.hasProperties = function(node, properties, parentNode = null) {
       ];
     }
 
-    if (propertyChecks.allowed === false && isDefined(propertyValue)) {
+    if (propertyChecks.allowed === false && isDefined(propertyValue) && !isNil(propertyValue)) {
       return [
         ...results,
         {

diff --git a/test/helper.js b/test/helper.js
@@ -99,7 +99,7 @@ function createElement(type, properties) {
   };
 
   const setParent = (property) => {
-    if (property.$type) {
+    if (property && property.$type) {
       const childModdleElement = property;
 
       childModdleElement.$parent = moddleElement;

diff --git a/test/utils/element.spec.js b/test/utils/element.spec.js
@@ -456,7 +456,7 @@ describe('utils/element', function() {
 
     describe('allowed', function() {
 
-      it('should not return errors', function() {
+      it('should not return errors (undefined)', function() {
 
         // given
         const serviceTask = createElement('bpmn:ServiceTask');
@@ -473,6 +473,25 @@ describe('utils/element', function() {
       });
 
 
+      it('should not return errors (null)', function() {
+
+        // given
+        const serviceTask = createElement('bpmn:ServiceTask', {
+          modelerTemplate: null
+        });
+
+        // when
+        const errors = hasProperties(serviceTask, {
+          modelerTemplate: {
+            allowed: false
+          }
+        });
+
+        // then
+        expect(errors).to.be.empty;
+      });
+
+
       it('should return errors', function() {
 
         // given