feat: more filter options for incidents #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @berkgok @Hard-Coder05 @JubayerJoy, |
saig0
requested changes
Oct 18, 2021
There was a problem hiding this comment.
@nitram509 thank you for your contribution 🎉
Your RP looks good and solves the issue 👍
I have a suggestion to improve the API. Please have a look at my comment.
saig0
approved these changes
Oct 19, 2021
There was a problem hiding this comment.
@nitram509 thank you for your fast replay. Everything looks good 👍
I'll merge your PR 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refers to issue #26
I figured out, that
.withProcessInstanceKey()does clash when using the same method name with more than one generic type (e.g. ProcessInstanceRecordValue and IncidenRecordValue end up in the same method signature).Seems to be a limit of Kotlin. Also, thinking of Java users, this would lead to problems in using the fluent interface.
So, I do propose to prefix by type. Examples:
That should make the use from/within Java more simple and readable.
Any feedback welcome