Add uid and gid params to accounts::account #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmckinst
added a commit
to mmckinst/puppet-accounts
that referenced
this pull request
Sep 29, 2015
The README.md shows an example of hard coding a UID but that functionality isn't in the module right now. Pull request camptocamp#14 has it so I merged it and resolved the merge conflict. Specifying the GID is also a nice feature, also included in pull request camptocamp#14 but if you do that, you need go create the group for the user (with the specified GID) before you create the user. Puppet does autorequire the group for the user, but just selects the next GID available, you need to manually create the group if you want a custom GID. See error below for what happens if you try to create a user with a custom UID and GID: ``` Error: Could not create user example: Execution of '/sbin/useradd -g 66666 -d /home/example -p * -u 66666 -m example' returned 6: useradd: group '66666' does not exist Error: /Stage[main]/Profiles::Base/Accounts::Account[@herp]/Accounts::Account[example]/User[example]/ensure: change from absent to present failed: Could not create user example: Execution of '/sbin/useradd -g 66666 -d /home/example -p * -u 66666 -m example' returned 6: useradd: group '66666' does not exist ```
mcanevet
force-pushed
the
dev/add_uid_and_gid
branch
from
26b324c to
0f854a4
Compare
mcanevet
force-pushed
the
dev/add_uid_and_gid
branch
from
0f854a4 to
5542cda
Compare
mcanevet
added a commit
that referenced
this pull request
Sep 30, 2015
Add uid and gid params to accounts::account
johnzimm
pushed a commit
to johnzimm/xx-puppet-module-accounts
that referenced
this pull request
Feb 24, 2016
The README.md shows an example of hard coding a UID but that functionality isn't in the module right now. Pull request camptocamp#14 has it so I merged it and resolved the merge conflict. Specifying the GID is also a nice feature, also included in pull request camptocamp#14 but if you do that, you need go create the group for the user (with the specified GID) before you create the user. Puppet does autorequire the group for the user, but just selects the next GID available, you need to manually create the group if you want a custom GID. See error below for what happens if you try to create a user with a custom UID and GID: ``` Error: Could not create user example: Execution of '/sbin/useradd -g 66666 -d /home/example -p * -u 66666 -m example' returned 6: useradd: group '66666' does not exist Error: /Stage[main]/Profiles::Base/Accounts::Account[@herp]/Accounts::Account[example]/User[example]/ensure: change from absent to present failed: Could not create user example: Execution of '/sbin/useradd -g 66666 -d /home/example -p * -u 66666 -m example' returned 6: useradd: group '66666' does not exist ```
johnzimm
pushed a commit
to johnzimm/xx-puppet-module-accounts
that referenced
this pull request
Feb 26, 2016
The README.md shows an example of hard coding a UID but that functionality isn't in the module right now. Pull request camptocamp#14 has it so I merged it and resolved the merge conflict. Specifying the GID is also a nice feature, also included in pull request camptocamp#14 but if you do that, you need go create the group for the user (with the specified GID) before you create the user. Puppet does autorequire the group for the user, but just selects the next GID available, you need to manually create the group if you want a custom GID. See error below for what happens if you try to create a user with a custom UID and GID: ``` Error: Could not create user example: Execution of '/sbin/useradd -g 66666 -d /home/example -p * -u 66666 -m example' returned 6: useradd: group '66666' does not exist Error: /Stage[main]/Profiles::Base/Accounts::Account[@herp]/Accounts::Account[example]/User[example]/ensure: change from absent to present failed: Could not create user example: Execution of '/sbin/useradd -g 66666 -d /home/example -p * -u 66666 -m example' returned 6: useradd: group '66666' does not exist ``` test for when someone has custom gid delete user's group with custom id too test for removing user and group we should only ensure the group if we're creating it deletion of the group, regardless of the gid, will happen automatically update test to reflect reality
johnzimm
pushed a commit
to johnzimm/xx-puppet-module-accounts
that referenced
this pull request
Feb 26, 2016
The README.md shows an example of hard coding a UID but that functionality isn't in the module right now. Pull request camptocamp#14 has it so I merged it and resolved the merge conflict. Specifying the GID is also a nice feature, also included in pull request camptocamp#14 but if you do that, you need go create the group for the user (with the specified GID) before you create the user. Puppet does autorequire the group for the user, but just selects the next GID available, you need to manually create the group if you want a custom GID. See error below for what happens if you try to create a user with a custom UID and GID: ``` Error: Could not create user example: Execution of '/sbin/useradd -g 66666 -d /home/example -p * -u 66666 -m example' returned 6: useradd: group '66666' does not exist Error: /Stage[main]/Profiles::Base/Accounts::Account[@herp]/Accounts::Account[example]/User[example]/ensure: change from absent to present failed: Could not create user example: Execution of '/sbin/useradd -g 66666 -d /home/example -p * -u 66666 -m example' returned 6: useradd: group '66666' does not exist ``` test for when someone has custom gid delete user's group with custom id too test for removing user and group we should only ensure the group if we're creating it deletion of the group, regardless of the gid, will happen automatically update test to reflect reality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.