Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: iso date milliseconds regex #481

Merged
merged 1 commit into from
May 7, 2024
Merged

fix: iso date milliseconds regex #481

merged 1 commit into from
May 7, 2024

Conversation

mdjastrzebski
Copy link
Member

@mdjastrzebski mdjastrzebski commented May 7, 2024 •
edited
Loading

Summary

Fix unescaped regex pattern (.)

Test plan

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 7, 2024

🦋 Changeset detected

Latest commit: 1ead494

The changes in this PR will be included in the next version bump.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mdjastrzebski mdjastrzebski changed the base branch from main to v1 May 7, 2024 13:09
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2024

Performance Comparison Report

  • Current: 39b6f6e - 2024-05-07 13:12:54Z
  • Baseline: main (5708d67) - 2024-05-07 13:11:35Z

Significant Changes To Duration

Name Type Duration Count
Other Component 10 render 114.4 ms → 118.5 ms (+4.1 ms, +3.6%) 4 → 4
fib 32 function 222.7 ms → 218.7 ms (-4.0 ms, -1.8%) 1 → 1
fib 31 function 147.5 ms → 140.2 ms (-7.3 ms, -5.0%) 1 → 1
Show details
Name Type Duration Count
Other Component 10 render Baseline
Mean: 114.4 ms
Stdev: 2.7 ms (2.4%)
Runs: 118 118 116 115 115 115 114 112 111 110

Current
Mean: 118.5 ms
Stdev: 18.0 ms (15.2%)
Runs: 162 135 123 114 112 111 110 110 109 99		 Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
fib 32 function Baseline
Mean: 222.7 ms
Stdev: 1.6 ms (0.7%)
Runs: 226.0 224.9 223.5 222.9 222.1 221.8 221.8 221.8 221.4 221.2

Current
Mean: 218.7 ms
Stdev: 0.5 ms (0.2%)
Runs: 219.0 219.0 219.0 218.9 218.9 218.9 218.9 218.8 218.6 217.4		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
fib 31 function Baseline
Mean: 147.5 ms
Stdev: 0.6 ms (0.4%)
Runs: 148.0 148.0 147.9 147.7 147.6 147.6 147.6 147.6 147.5 145.9

Current
Mean: 140.2 ms
Stdev: 5.0 ms (3.6%)
Runs: 145.1 144.7 144.2 144.0 142.1 141.1 140.8 135.4 132.6 132.0		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Meaningless Changes To Duration

Show entries
Name Type Duration Count
Async Component render 189.1 ms → 191.3 ms (+2.2 ms, +1.2%) 7 → 7
fib 30 function 83.0 ms → 82.1 ms (-0.9 ms, -1.1%) 1 → 1
Other Component 10 legacy scenario render 114.8 ms → 116.1 ms (+1.3 ms, +1.1%) 4 → 4
Other Component 20 render 117.5 ms → 115.3 ms (-2.3 ms, -1.9%) 4 → 4
Show details
Name Type Duration Count
Async Component render Baseline
Mean: 189.1 ms
Stdev: 6.7 ms (3.6%)
Runs: 199 195 194 193 192 188 187 184 182 177

Current
Mean: 191.3 ms
Stdev: 7.4 ms (3.9%)
Runs: 201 201 198 197 192 188 185 185 184 182		 Baseline
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7

Current
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
fib 30 function Baseline
Mean: 83.0 ms
Stdev: 1.5 ms (1.8%)
Runs: 86.8 83.4 83.3 83.1 82.8 82.8 82.3 82.2 82.2 81.1

Current
Mean: 82.1 ms
Stdev: 1.1 ms (1.4%)
Runs: 84.4 83.9 81.7 81.7 81.6 81.6 81.5 81.4 81.4 81.3		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Other Component 10 legacy scenario render Baseline
Mean: 114.8 ms
Stdev: 4.4 ms (3.8%)
Runs: 120 119 119 117 116 116 113 112 109 107

Current
Mean: 116.1 ms
Stdev: 6.8 ms (5.9%)
Runs: 130 121 120 119 116 114 113 112 111 105		 Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Other Component 20 render Baseline
Mean: 117.5 ms
Stdev: 3.9 ms (3.3%)
Runs: 126 122 121 121 121 121 120 119 119 117 117 116 116 115 115 115 114 113 111 111

Current
Mean: 115.3 ms
Stdev: 4.7 ms (4.0%)
Runs: 126 123 120 119 119 117 117 116 116 116 115 114 113 113 112 112 110 110 109 108		 Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4

Changes To Count

There are no entries

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against 1ead494

@mdjastrzebski mdjastrzebski merged commit e659bc5 into v1 May 7, 2024
2 checks passed
@mdjastrzebski mdjastrzebski deleted the fix/date-time-regex branch May 7, 2024 13:13
mdjastrzebski added a commit that referenced this pull request Jun 16, 2024
@mdjastrzebski @guvenkaranfil
v1 (#456)
ebcf9d6 
* refactor: rename `meassurePerformance` to `measureRenders` (#433)

* chore: v1.0.0-beta

* docs: update changelogs

* docs: migration guide

* chore: update snapshots

* chore: update node ver on GH

* chore: v1.0.0-rc

* chore: v1.0.0-rc.1

* chore: reorganize repo deps (#477)

* refactor: migrate deps

* chore: dedup eslint

* chore: fix eslint deps

* chore: yarn berry (#478)

* chore: yarn berry (wip)

chore: forward reassure cli in the main package

chore: remove --force

chore: fix ci

chore: fix ci

chore: fix typecheck

chore: fix danger

chore: fix danger

chore: fix ci

chore: fix danger

refactor: tweaks

* chore: workspace deps

* chore: add changeset

* chore: v1.0.0-rc.2

* chore: fix versions

* chore: fix version deps between packages

* chore: v1.0.0-rc.3

* fix: iso date milliseconds regex (#481)

* chore: check deps consistency (#482)

* chore: pdate deps 2024-05-09 (#484)

* chore: update deps

* chore: fix lint

* chore: update danger (#483)

chore: update danger.js

* chore: upgrade RN / test app (#485)

* chore: upgrade turbo

* chore: update React Native / test app

* chore: fix wasm error

* chore: updata other deps (#486)

* chore: update other deps

* chore: update peer deps

* chore: update deps

* feat: enable wasm by default (#488)

* chore: tweak workflow (#490)

* chore: tweak workflow

* chore: update docs

* chore: export types (#489)

* chore: export types

* chore: gen yarn.lock

* chore: tweaks docs

* refactor: rename types

* chore: add docs

* chore: clean scripts (#491)

* chore: clean scripts

* chore: tweak turbo

* chore: add missing changeset

* chore: v1.0.0-beta.4

* chore: regenerate yarn.lock

* feat: detect unnecessary render and warn user (#468)

* feat: detect unnecessary render and warn user

feat: capture json representations in an array to compare after for unnecessary rendering

fix: get current testingLibrary for comparasion only react-native for now

fix: save json representation instead of string for rendered component state and compare changes between states using dfs

fix: test name

fix: update comparasion function and save compare results into output.json and show comparation results in the end of the test

fix: update interface and variable names based on pr recommendatations

chore: rebase to v1

* refactor: improve output formatting

* refactor: fix typo

* refactor: remove unnecessary warning

* refactor: improve testing

* refactor: improve report criteria

* refactor: improve naming

* refactor: improve code structure & tests

* refactor: tweaks

* feat: improve markdown output

* refactor: custom tree comparer

* refactor: clean up code

* refactor: update JSON structure

* refactor: use "initial update count" naming

* chore: fix lint

* chore: improve tests

* refactor: tweaks

* docs: update

* refactor: self code review

* docs: tweaks

* chore: add changeset

* refactor: final tweaks

---------

Co-authored-by: Guven Karanfil <[email protected]>
Co-authored-by: Maciej Jastrzebski <[email protected]>

* chore: v1.0.0-rc.5

* chore: fix yarn.lock

* chore: fix reassure-tests.sh

---------

Co-authored-by: Güven Karanfil <[email protected]>
Co-authored-by: Guven Karanfil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mdjastrzebski