Fix: Linking during Android build for new arch #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BartoszKlonowski
force-pushed
the
fix/594/android-new-arch-linking
branch
from
f3058c4 to
a5623af
Compare
The CI check should fail, but only for the new arch check for Android. Old arch should still succeed. This commit TEMPORARILY reverts the main fix for the issue.
This reverts commit 2e49aa8.
okwasniewski
approved these changes
Apr 19, 2024
artus9033
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #594
It basically removes the unused and non-existing libraries from CMake config so that we don't require them when we don't really have them (nor build them on our own).
I briefly checked for the rest of the libs that are included there to see whether there's any other that can be removed, but it seems all other are indeed used and available during the build.
This pull request also introduces the job for building the new arch for Android, so that we can always check whether we are good there.