Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): Wrong sample size exit logic #19

Merged
merged 1 commit into from
Mar 18, 2019
Merged

fix(android): Wrong sample size exit logic #19

merged 1 commit into from
Mar 18, 2019

Conversation

guhungry
Copy link
Contributor

Trancever
Trancever approved these changes Mar 18, 2019
View reviewed changes
Copy link
Contributor

@Trancever Trancever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and thanks for provided reference!

@Trancever Trancever merged commit 9d62729 into callstack:master Mar 18, 2019
@Trancever
Copy link
Contributor

I'll try to release new version today.

@guhungry guhungry deleted the android-fix-sample-size branch March 19, 2019 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trancever Trancever Trancever approved these changes

@krizzu krizzu krizzu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guhungry @Trancever @krizzu