Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typings): Wrong type for ImageCropData.resizeMode #17

Merged
merged 1 commit into from
Mar 13, 2019
Merged

fix(typings): Wrong type for ImageCropData.resizeMode #17

merged 1 commit into from
Mar 13, 2019

Conversation

guhungry
Copy link
Contributor

@guhungry guhungry commented Mar 13, 2019 •
edited
Loading

Current typing for ImageCropData.resizeMode is wrong
Currently it typed as object instead of string of ("contain" | "cover" | "stretch")

Note

typings is not included in current npm release

cpojer
cpojer approved these changes Mar 13, 2019
View reviewed changes
Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Trancever Trancever merged commit 45b4b23 into callstack:master Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpojer cpojer cpojer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guhungry @cpojer @Trancever