Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add caller settings to loadBabelOptions() #1356

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

layershifter
Copy link
Contributor

@layershifter layershifter commented Sep 26, 2023

Partially fixes #1348.

Motivation

In cases when @babel/preset-env is used in user configs (for example, .babelrc) and they don't have explicit modules: false, we will have to deal with CJS instead of ESM.

To solve this, we need to specify caller params to avoid CJS transforms:

https://github.com/babel/babel/blob/e0375121bfea96d277f49543dc543f116523cfd0/packages/babel-preset-env/src/index.ts#L270-L283

Summary

  • Caller's config is updated
  • Versions in package.json files are fixed

@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2023

🦋 Changeset detected

Latest commit: c75521d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@linaria/testkit Patch
@linaria/utils Patch
webpack5-example Patch
@linaria/atomic Patch
@linaria/babel-preset Patch
@linaria/cli Patch
@linaria/core Patch
@linaria/esbuild Patch
@linaria/griffel Patch
@linaria/react Patch
@linaria/rollup Patch
@linaria/shaker Patch
@linaria/stylelint Patch
@linaria/tags Patch
@linaria/vite Patch
@linaria/webpack5-loader Patch
linaria-website Patch
linaria Patch
@linaria/webpack4-loader Patch
vpssr-linaria-solid-example Patch
esbuild-example Patch
rollup-example Patch
vite-example Patch
@linaria/webpack-loader Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@layershifter layershifter marked this pull request as ready for review September 26, 2023 16:02
@Anber Anber merged commit 727dc2b into callstack:master Sep 26, 2023
@layershifter layershifter deleted the fix/babel-called branch September 26, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build errors with Linaria@5 and Rollup/Vite
2 participants