fix: keep side effects from modules #1190
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #1189.
Summary
Generally there two kinds of side-effects:
We want to keep only imports that contain code. Implemented
shouldKeepSideEffect()
to check if an import should stay.The tricky part is that
shouldKeepSideEffect('object.values')
isfalse
💥 However, we can't do much at this step: to be sure we need to resolve imports 🙃Test plan
New tests have been added.