fix(struct): add encoding check to not pass undefined values (#2)

callmehiphop · Jun 14, 2019 · 6034685 · 6034685
1 parent ead6908
commit 6034685
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/index.ts b/index.ts
@@ -127,6 +127,8 @@ export const struct = {
   encode(json: JsonObject): Struct {
     const fields = {};
     Object.keys(json).forEach(key => {
+      // If value is undefined, do not encode it.
+      if (!json[key]) return;
       fields[key] = value.encode(json[key]);
     });
     return {fields};

diff --git a/test.ts b/test.ts
@@ -8,6 +8,12 @@ const obj = {
   yes: true
 };
 
+const objWithUndefined = {
+  foo: 'bar',
+  yes: true,
+  isUndefined: undefined
+};
+
 const listValue = {
   values: [{
     kind: 'nullValue',
@@ -172,6 +178,11 @@ test('struct.encode', t => {
   t.deepEqual(actual, structValue);
 });
 
+test('struct.encode - undefined value', t => {
+  const actual = struct.encode(objWithUndefined);
+  t.deepEqual(actual, structValue);
+});
+
 test('struct.decode', t => {
   const actual = struct.decode(structValue);
   t.deepEqual(actual, obj);