Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: variant input and prediction #53

Merged
merged 6 commits into from
Aug 13, 2021

Conversation

sachdeva-shrey
Copy link
Collaborator

Signed-off-by: sachdeva-shrey [email protected]

Type of change

Please tick options that are relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Changes

  1. Add onVariantAdded and onGetPredictions custom events.
  2. Add variant option to createFeature, which set is set to false by default.
  3. Created single variant input and multiple variant input popups.

Flags

  1. Requires some refactoring.
  2. Variant deletion feature incomplete as of now.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Signed-off-by: sachdeva-shrey <[email protected]>
Signed-off-by: sachdeva-shrey <[email protected]>
Signed-off-by: sachdeva-shrey <[email protected]>
@sachdeva-shrey sachdeva-shrey marked this pull request as ready for review August 3, 2021 19:46
Signed-off-by: sachdeva-shrey <[email protected]>
Copy link
Contributor

@kwsamarasinghe kwsamarasinghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only one clarification, is the VEP related feature can be generalized and used in the feature viewer, i.e to add another functionality on AA selection?. Please merge.

function createFeature(sequence, div, options) {
// var nxSeq = sequence.startsWith('NX_') ? true : false;
var self = this;
// if (!div) var div = window;
this.events = {
FEATURE_SELECTED_EVENT: "feature-viewer-position-selected",
FEATURE_DESELECTED_EVENT: "feature-viewer-position-deselected",
ZOOM_EVENT: "feature-viewer-zoom-altered"
ZOOM_EVENT: "feature-viewer-zoom-altered",
GET_PREDICTIONS_EVENT: "feature-viewer-vep-predictions",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this to support VEP related feature?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is the event we're calling when the user clicks on the Get Predictions button, it retrieves the final variant values added through the popups.

@sachdeva-shrey sachdeva-shrey merged commit 254d35e into calipho-sib:master Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants