-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: variant input and prediction #53
feat: variant input and prediction #53
Conversation
Signed-off-by: sachdeva-shrey <[email protected]>
Signed-off-by: sachdeva-shrey <[email protected]>
Signed-off-by: sachdeva-shrey <[email protected]>
Signed-off-by: sachdeva-shrey <[email protected]>
Signed-off-by: sachdeva-shrey <[email protected]>
Signed-off-by: sachdeva-shrey <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only one clarification, is the VEP related feature can be generalized and used in the feature viewer, i.e to add another functionality on AA selection?. Please merge.
function createFeature(sequence, div, options) { | ||
// var nxSeq = sequence.startsWith('NX_') ? true : false; | ||
var self = this; | ||
// if (!div) var div = window; | ||
this.events = { | ||
FEATURE_SELECTED_EVENT: "feature-viewer-position-selected", | ||
FEATURE_DESELECTED_EVENT: "feature-viewer-position-deselected", | ||
ZOOM_EVENT: "feature-viewer-zoom-altered" | ||
ZOOM_EVENT: "feature-viewer-zoom-altered", | ||
GET_PREDICTIONS_EVENT: "feature-viewer-vep-predictions", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this to support VEP related feature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is the event we're calling when the user clicks on the Get Predictions
button, it retrieves the final variant values added through the popups.
Signed-off-by: sachdeva-shrey [email protected]
Type of change
Please tick options that are relevant.
Changes
onVariantAdded
andonGetPredictions
custom events.variant
option tocreateFeature
, which set is set tofalse
by default.Flags
Checklist: