Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate to webpack #50

Merged

Conversation

sachdeva-shrey
Copy link
Collaborator

@sachdeva-shrey sachdeva-shrey commented Jun 2, 2021

Signed-off-by: sachdeva-shrey [email protected]

Type of change

Please tick options that are relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Changes

  1. Migrate to Webpack from Browserify and Grunt which is a much more powerful tool. This make the code base less complicated and easier to maintain in the future.
  2. Fixes the local development server which wasn't working earlier using Webpack.
  3. Removes Bower as a dependency and migrate to NPM/Yarn.
  4. When loading with CDN, previously all the functions (NextprotNXUtilsFeatureViewerNXViewerUtilsnxFeatureViewer) were being loaded as globals separately. Now, it would be loaded under the same namespace i.e. FeatureViewer so that it doesn't pollute the global window object. The FeatureViewer function will now be createFeature instead and it can be referred as new FeatureViewer.createFeature().
  5. Exposes neXtProt features to be through NPM/Yarn which weren't available previously.
  6. Fixes all examples in /examples directory.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@kwsamarasinghe kwsamarasinghe changed the base branch from master to develop June 16, 2021 14:15
@kwsamarasinghe kwsamarasinghe merged commit fe1a103 into calipho-sib:develop Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants