refactor: Moving from jest to vitest #9035

leog · 2023-05-22T13:11:45Z

What does this PR do?

Moving unit testing framework from Jest to Vitest in order to speed things up.

Going from this:

To this:

Marking a 85.3% decrease in time, even running more tests than Jest.

Type of change

Chore (refactoring code, technical debt, workflow improvements)

vercel · 2023-05-22T13:11:53Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
cal	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 24, 2023 11:15pm

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
ui	⬜️ Ignored (Inspect)	Visit Preview		May 24, 2023 11:15pm

socket-security · 2023-05-22T13:20:10Z

New dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary

Issue	Status
Install scripts	✅ 0 issues
Native code	✅ 0 issues
Bin script shell injection	✅ 0 issues
Unresolved require	✅ 0 issues
Invalid package.json	✅ 0 issues
HTTP dependency	✅ 0 issues
Git dependency	✅ 0 issues
Potential typo squat	✅ 0 issues
Known Malware	✅ 0 issues
Telemetry	✅ 0 issues
Protestware/Troll package	✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package	Capability Access	`+/-` Transitive Count	Publisher
[email protected]	None	`+8`	domenic
[email protected]	None	`+1`	eratio
[email protected]	None	`+2`	simenb

🚮 Removed packages: @types/[email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]

github-actions · 2023-05-22T13:24:14Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

deploysentinel · 2023-05-22T17:36:06Z

Current Playwright Test Results Summary

✅ 114 Passing - ⚠️ 6 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/24/2023 11:34:59pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 27ef504

Started: 05/24/2023 11:20:58pm UTC

⚠️ Flakes

📄 apps/web/playwright/reschedule.e2e.ts • 2 Flakes

Top 1 Common Error Messages

`null`	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Reschedule Tests -- new-booker Should do a booking request reschedule from /bookings Retry 1 • Initial Attempt	0.77% (3) 3 / 388 runs failed over last 7 days	1.80% (7) 7 / 388 runs flaked over last 7 days
Reschedule Tests -- old-booker Opt in event should be ACCEPTED when rescheduled by OWNER Retry 1 • Initial Attempt	0% (0) 0 / 375 runs failed over last 7 days	2.40% (9) 9 / 375 runs flaked over last 7 days

📄 apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Event Types tests user -- old-booker can duplicate an existing event type Retry 1 • Initial Attempt	0% (0) 0 / 394 runs failed over last 7 days	1.27% (5) 5 / 394 runs flaked over last 7 days

📄 apps/web/playwright/embed-code-generator.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Embed Code Generator Tests Event Type Edit Page open Embed Dialog for the Event Type Retry 1 • Initial Attempt	3.27% (13) 13 / 397 runs failed over last 7 days	29.97% (119) 119 / 397 runs flaked over last 7 days

📄 apps/web/playwright/booking-seats.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Booking with Seats -- new-booker Reschedule for booking with seats -- old-booker Should reschedule booking with seats and if everyone rescheduled it should be deleted Retry 1 • Initial Attempt	0% (0) 0 / 406 runs failed over last 7 days	85.47% (347) 347 / 406 runs flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests should be able to reschedule Retry 2 • Retry 1 • Initial Attempt	9.09% (1) 1 / 11 run failed over last 7 days	36.36% (4) 4 / 11 runs flaked over last 7 days

View Detailed Build Results

zomars · 2023-05-22T22:37:06Z

I'm loving this! Nice job @leog

Just for completeness sake. What are the drawbacks of abandoning jest in our codebase?

zomars · 2023-05-23T01:07:48Z

.prettierignore

@@ -7,6 +7,7 @@ public

 *.lock
 *.log
+*.test.ts


Why is this needed?

Some tests need to import prisma before the actual code using prisma gets run, and Prettier was reorganizing the imports everywhere breaking this. I added this to avoid prettier reorganizing imports in tests.

hariombalhara · 2023-05-23T07:44:36Z

apps/web/test/lib/getTimezone.test.ts

 });

 it("should filter cities for a valid city name", () => {
  expect(filterByCities("San Francisco", cityData)).toMatchInlineSnapshot(`
-    Array [


I had always thought why it was needed. Now, vitest removing it ❤️

.vscode/launch.json

PeerRich · 2023-05-23T08:44:08Z

happy to merge once open questions were answered. changes can be done in a follow up PR

…to chore/vitest-migration

leog · 2023-05-23T13:42:48Z

Just for completeness sake. What are the drawbacks of abandoning jest in our codebase?

@zomars There is no apparent drawback other than immersing ourselves into a new framework which can lead to unknowns although Vitest is being used more and more these days. Not to mention Vitest has been designed with a Jest compatible API. More info about migration and similarities/differences here.

All in all, I think we should give it a chance, the time difference is huge, and locally is ludicrous, see:

Moving to vitest

403f95d

leog requested a review from hariombalhara as a code owner May 22, 2023 13:11

leog requested a review from a team May 22, 2023 13:11

vercel bot deployed to Preview – ui May 22, 2023 13:15 View deployment

vercel bot deployed to Preview – cal May 22, 2023 13:18 View deployment

Rearranging test

9ada706

vercel bot deployed to Preview – cal May 22, 2023 13:33 View deployment

Merge branch 'main' into chore/vitest-migration

0709b37

vercel bot deployed to Preview – cal May 22, 2023 14:32 View deployment

Fixing prettier linting

068136f

leog added the ♻️ autoupdate tells kodiak to keep this branch up-to-date label May 22, 2023

vercel bot deployed to Preview – cal May 22, 2023 17:29 View deployment

Merge branch 'main' into chore/vitest-migration

0c9ee50

vercel bot deployed to Preview – cal May 22, 2023 18:06 View deployment

Merge branch 'main' into chore/vitest-migration

f8732e1

vercel bot deployed to Preview – ui May 22, 2023 22:16 View deployment

vercel bot deployed to Preview – cal May 22, 2023 22:18 View deployment

Merge branch 'main' into chore/vitest-migration

a9b82f7

vercel bot deployed to Preview – cal May 22, 2023 22:40 View deployment

zomars reviewed May 23, 2023

View reviewed changes

Merge branch 'main' into chore/vitest-migration

cfaed2b

vercel bot deployed to Preview – ui May 23, 2023 01:18 View deployment

vercel bot deployed to Preview – cal May 23, 2023 01:20 View deployment

hariombalhara reviewed May 23, 2023

View reviewed changes

.vscode/launch.json Outdated Show resolved Hide resolved

PeerRich removed this pull request from the merge queue due to a manual request May 23, 2023

leog added 2 commits May 23, 2023 09:44

Reverting launch.json

f4a2601

Merge branch 'chore/vitest-migration' of github.com:calcom/cal.com in…

373b56a

…to chore/vitest-migration

vercel bot deployed to Preview – cal May 23, 2023 12:51 View deployment

Adjustments

03fb10d

vercel bot deployed to Preview – cal May 23, 2023 13:40 View deployment

Merge branch 'main' into chore/vitest-migration

23c531b

vercel bot deployed to Preview – cal May 23, 2023 13:47 View deployment

vercel bot deployed to Preview – ui May 23, 2023 13:48 View deployment

PeerRich changed the title ~~Moving from jest to vitest~~ refactor: Moving from jest to vitest May 24, 2023

emrysal added 2 commits May 24, 2023 20:36

Merge branch 'main' into chore/vitest-migration

e62fb10

Merged with main and regenerated lockfile

e7e9f6d

vercel bot deployed to Preview – ui May 24, 2023 18:42 View deployment

vercel bot deployed to Preview – cal May 24, 2023 18:45 View deployment

leog added 2 commits May 24, 2023 17:22

Fixing tests for API

3f1f9d6

Merge branch 'main' into chore/vitest-migration

6f8291a

vercel bot deployed to Preview – ui May 24, 2023 20:27 View deployment

vercel bot deployed to Preview – cal May 24, 2023 20:37 View deployment

Yarn updated, docs is gone

766c91a

emrysal enabled auto-merge May 24, 2023 21:45

vercel bot deployed to Preview – cal May 24, 2023 21:50 View deployment

emrysal approved these changes May 24, 2023

View reviewed changes

Merge branch 'main' into chore/vitest-migration

27ef504

vercel bot deployed to Preview – cal May 24, 2023 23:15 View deployment

emrysal added this pull request to the merge queue May 24, 2023

Merged via the queue into main with commit 734382b May 25, 2023

emrysal deleted the chore/vitest-migration branch May 25, 2023 00:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: Moving from jest to vitest #9035

refactor: Moving from jest to vitest #9035

leog commented May 22, 2023 •

edited

Loading

vercel bot commented May 22, 2023 •

edited

Loading

socket-security bot commented May 22, 2023 •

edited

Loading

github-actions bot commented May 22, 2023 •

edited

Loading

deploysentinel bot commented May 22, 2023 •

edited

Loading

Top 1 Common Error Messages

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

zomars commented May 22, 2023

zomars May 23, 2023

leog May 23, 2023

hariombalhara May 23, 2023

PeerRich commented May 23, 2023 •

edited

Loading

leog commented May 23, 2023

refactor: Moving from jest to vitest #9035

refactor: Moving from jest to vitest #9035

Conversation

leog commented May 22, 2023 • edited Loading

What does this PR do?

Type of change

vercel bot commented May 22, 2023 • edited Loading

socket-security bot commented May 22, 2023 • edited Loading

github-actions bot commented May 22, 2023 • edited Loading

📦 Next.js Bundle Analysis for @calcom/web

deploysentinel bot commented May 22, 2023 • edited Loading

Current Playwright Test Results Summary

⚠️ Flakes

Top 1 Common Error Messages

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

zomars commented May 22, 2023

zomars May 23, 2023

Choose a reason for hiding this comment

leog May 23, 2023

Choose a reason for hiding this comment

hariombalhara May 23, 2023

Choose a reason for hiding this comment

PeerRich commented May 23, 2023 • edited Loading

leog commented May 23, 2023

leog commented May 22, 2023 •

edited

Loading

vercel bot commented May 22, 2023 •

edited

Loading

socket-security bot commented May 22, 2023 •

edited

Loading

github-actions bot commented May 22, 2023 •

edited

Loading

deploysentinel bot commented May 22, 2023 •

edited

Loading

PeerRich commented May 23, 2023 •

edited

Loading