Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Booking confirmation: Cancelled event icon regression #14018

Merged
merged 12 commits into from
Mar 12, 2024
Merged

fix: Booking confirmation: Cancelled event icon regression #14018

merged 12 commits into from
Mar 12, 2024

Conversation

ASQUAREEE
Copy link
Contributor

@ASQUAREEE ASQUAREEE commented Mar 7, 2024 •
edited by Udit-takkar
Loading

Fixes: #14016

I just converted an X icon to an Xcircle icon and fixed the issue.

@graphite-app graphite-app bot requested review from a team March 7, 2024 16:25
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Mar 7, 2024
@vercel Vercel
Copy link

vercel bot commented Mar 7, 2024

@ASQUAREEE is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024 •
edited
Loading

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@socket-security Socket Security
Copy link

socket-security bot commented Mar 7, 2024 •
edited
Loading

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@keithwillcode keithwillcode changed the title fix: #14016 fix: Booking confirmation: Cancelled event icon regression Mar 7, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Mar 7, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (03/07/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (03/07/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (03/07/24)

1 label was added to this PR based on Keith Williams's automation.

keithwillcode
keithwillcode previously approved these changes Mar 7, 2024
View reviewed changes
@keithwillcode keithwillcode enabled auto-merge (squash) March 7, 2024 16:30
@PeerRich PeerRich requested a review from keithwillcode March 7, 2024 16:41
@PeerRich PeerRich dismissed keithwillcode’s stale review March 7, 2024 16:41

this is not the right icon

PeerRich
PeerRich previously requested changes Mar 7, 2024
View reviewed changes
Copy link
Member

@PeerRich PeerRich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats not the right icon. i think we have a svg icon somewhere

@graphite-app Graphite App
Copy link

graphite-app bot commented Mar 7, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (03/07/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (03/07/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (03/07/24)

1 label was added to this PR based on Keith Williams's automation.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024 •
edited
Loading

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

auto-merge was automatically disabled March 7, 2024 17:36

Head branch was pushed to by a user without write access

@CLAassistant
Copy link

CLAassistant commented Mar 7, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ASQUAREEE ASQUAREEE requested a review from PeerRich March 7, 2024 17:48
Udit-takkar
Udit-takkar reviewed Mar 8, 2024
View reviewed changes
apps/web/modules/bookings/views/bookings-single-view.tsx Outdated
Comment on lines 358 to 360
{isCancelled && (
<img src="/booking-cancelled.svg" alt="cancelled image" className="h-8 w-8" />
)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look good in dark mode

Udit-takkar
Udit-takkar reviewed Mar 8, 2024
View reviewed changes
apps/web/styles/globals.css
@@ -17,7 +17,7 @@
--cal-bg-info: hsla(218,83%,98%,1);
--cal-bg-success: hsla(134,76%,94%,1);
--cal-bg-attention: hsla(37, 86%, 92%, 1);
--cal-bg-error: hsla(3,66,93,1);
--cal-bg-error: hsla(3,66%,93%,1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the bug in light mode. I have removed the svg that you added

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Udit-takkar
Udit-takkar approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have fixed it now

Screenshot 2024-03-08 at 11 11 43 AM

@Udit-takkar Udit-takkar enabled auto-merge (squash) March 8, 2024 05:43
@github-actions github-actions bot added Low priority Created by Linear-GitHub Sync 🐛 bug Something isn't working 📉 regressing This used to work. Now it doesn't anymore. 🚧 wip / in the making labels Mar 11, 2024
@PeerRich PeerRich added this to the v3.9 milestone Mar 11, 2024
@Udit-takkar Udit-takkar merged commit 4eb11e7 into calcom:main Mar 12, 2024
30 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeerRich PeerRich PeerRich approved these changes

@Udit-takkar Udit-takkar Udit-takkar approved these changes

@keithwillcode keithwillcode Awaiting requested review from keithwillcode

Assignees
No one assigned
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync Low priority Created by Linear-GitHub Sync 📉 regressing This used to work. Now it doesn't anymore.
Projects
None yet
Milestone
v3.9
Development

Successfully merging this pull request may close these issues.

[CAL-3274] Booking confirmation: Cancelled event icon regression
5 participants
@ASQUAREEE @CLAassistant @keithwillcode @PeerRich @Udit-takkar