fix: Infinite loop in timezones on the negative side of UTC #12063

emrysal · 2023-10-24T16:44:51Z

What does this PR do?

Test by:

Run new tests against old code; observe there's an infinite loop
Then run tests against updated code.

vercel · 2023-10-24T16:45:00Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ai	❌ Failed (Inspect)			Oct 25, 2023 11:51am
dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 25, 2023 11:51am
qa	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Oct 25, 2023 11:51am

4 Ignored Deployments

Name	Status	Preview	Updated (UTC)
api	⬜️ Ignored (Inspect)	Visit Preview	Oct 25, 2023 11:51am
cal	⬜️ Ignored (Inspect)	Visit Preview	Oct 25, 2023 11:51am
cal-demo	⬜️ Ignored (Inspect)	Visit Preview	Oct 25, 2023 11:51am
ui	⬜️ Ignored (Inspect)	Visit Preview	Oct 25, 2023 11:51am

github-actions · 2023-10-24T16:45:05Z

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

packages/features/calendars/lib/getAvailableDatesInMonth.test.ts

github-actions · 2023-10-24T16:52:58Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

deploysentinel · 2023-10-24T17:00:58Z

Current Playwright Test Results Summary

✅ 208 Passing - ⚠️ 7 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/25/2023 11:54:03am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: db0a11a

Started: 10/25/2023 11:50:00am UTC

⚠️ Flakes

📄 apps/web/playwright/login.2fa.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
2FA Tests should allow a user to enable 2FA and login using 2FA Retry 1 • Initial Attempt	0.34% (1) 1 / 296 run failed over last 7 days	29.73% (88) 88 / 296 runs flaked over last 7 days

📄 apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Event Types tests user Different Locations Tests can add Attendee Phone Number location and book with it Retry 1 • Initial Attempt	0% (0) 0 / 306 runs failed over last 7 days	3.59% (11) 11 / 306 runs flaked over last 7 days

📄 apps/web/playwright/change-username.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Change username on settings User can change username to include periods(or dots) Retry 1 • Initial Attempt	0% (0) 0 / 97 runs failed over last 7 days	34.02% (33) 33 / 97 runs flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests should be able to reschedule Retry 2 • Retry 1 • Initial Attempt	7.21% (22) 22 / 305 runs failed over last 7 days	90.16% (275) 275 / 305 runs flaked over last 7 days

📄 apps/web/playwright/teams.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Teams Non admin team members cannot create team in org Retry 1 • Initial Attempt	0.34% (1) 1 / 298 run failed over last 7 days	20.81% (62) 62 / 298 runs flaked over last 7 days

📄 apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
FORM_SUBMITTED on submitting team form, triggers team webhook Retry 1 • Initial Attempt	0.33% (1) 1 / 299 run failed over last 7 days	12.37% (37) 37 / 299 runs flaked over last 7 days

📄 apps/web/playwright/availability.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Availablity tests Availability pages Retry 1 • Initial Attempt	0% (0) 0 / 305 runs failed over last 7 days	1.31% (4) 4 / 305 runs flaked over last 7 days

View Detailed Build Results

zomars · 2023-10-24T17:34:28Z

Can we check with e2e are failing?

zomars · 2023-10-24T18:51:16Z

Maybe unrelated but I'm getting this test failure locally. cc @CarinaWolli I think I've shared this with you before

CarinaWolli · 2023-10-24T18:56:44Z

Maybe unrelated but I'm getting this test failure locally. cc @CarinaWolli I think I've shared this with you before

@zomars That's unrelated, investigating right now. Somehow dayjs has some different results depending what tz your system is running on

…hub.com:calcom/cal.com into bugfix/get-available-dates-negative-utc-offsets

emrysal · 2023-10-24T19:13:29Z

@zomars not entirely unrelated, turns out after the test the system time wasn't reverted, and some of our e2e tests are failing on the new system time - I'm pushing a fix to revert to real system time for now but it's a problem that that test fails in different system times.

…hub.com:calcom/cal.com into bugfix/get-available-dates-negative-utc-offsets

Dismiss for reapproval

alishaz-polymath · 2023-10-25T06:00:36Z

The new test passes for me for both old and updated code 😮

hariombalhara · 2023-10-25T06:47:41Z

Same here, but the bug is actually fixed. Trying to see if I can fix the test.

hariombalhara · 2023-10-25T07:34:10Z

@emrysal I found that we need to fake the timezone using TZ env variable in Vitest.

So, I added the concept of timeZone dependent tests and marked these tests as timezone dependent by having an extension test.timezone.ts

Doing this I was able to replicate that infinite loop scenario in main with the tests. But even with the fix, I see some expectations mismatch here.

Passing with Asia/Kokata

Failing with America/Los_Angeles

Also, feel free to revert the commit, if it's not the right approach. I was debugging and just went ahead with this approach.

emrysal · 2023-10-25T11:41:06Z

@hariombalhara thanks! Turned out the test was broken and casting to UTC - fixed the cast and pushed.

keithwillcode

Updated code changes look good. Will wait for tests to pass to merge.

alishaz-polymath

Tested Locally, the new test spins in infinite loop with the old code. With the new code, test works fine 🚀

fix: Infinite loop in timezones on the negative side of UTC

230bc3e

emrysal requested a review from keithwillcode October 24, 2023 16:45

emrysal requested a review from zomars October 24, 2023 16:45

zomars added the core area: core, team members only label Oct 24, 2023

emrysal requested a review from CarinaWolli October 24, 2023 16:45

keithwillcode previously approved these changes Oct 24, 2023

View reviewed changes

packages/features/calendars/lib/getAvailableDatesInMonth.test.ts Show resolved Hide resolved

keithwillcode reviewed Oct 24, 2023

View reviewed changes

packages/features/calendars/lib/getAvailableDatesInMonth.test.ts Outdated Show resolved Hide resolved

emrysal commented Oct 24, 2023

View reviewed changes

packages/features/calendars/lib/getAvailableDatesInMonth.test.ts Outdated Show resolved Hide resolved

emrysal dismissed keithwillcode’s stale review via 60eb2a1 October 24, 2023 16:52

Update packages/features/calendars/lib/getAvailableDatesInMonth.test.ts

60eb2a1

vercel bot deployed to Preview – dev October 24, 2023 17:03 View deployment

vercel bot deployed to Preview – ai October 24, 2023 18:12 View deployment

vercel bot deployed to Preview – ui October 24, 2023 18:16 View deployment

vercel bot deployed to Preview – cal-demo October 24, 2023 18:54 View deployment

emrysal added 2 commits October 24, 2023 16:11

Revert back to real system time after test

10f2f01

Merge branch 'bugfix/get-available-dates-negative-utc-offsets' of git…

5ec8067

…hub.com:calcom/cal.com into bugfix/get-available-dates-negative-utc-offsets

vercel bot deployed to Preview – ai October 24, 2023 19:29 View deployment

vercel bot deployed to Preview – dev October 24, 2023 19:30 View deployment

vercel bot deployed to Preview – cal-demo October 24, 2023 19:30 View deployment

zomars added the High priority Created by Linear-GitHub Sync label Oct 24, 2023

zomars mentioned this pull request Oct 24, 2023

test: Create E2E tests for bookings with custom/required Long Text + other questions (teste2e-longTextQuestion) #11559

Merged

zomars removed the High priority Created by Linear-GitHub Sync label Oct 24, 2023

vercel bot had a problem deploying to Preview – ai October 24, 2023 22:07 Failure

vercel bot deployed to Preview – dev October 24, 2023 22:14 View deployment

emrysal added 2 commits October 25, 2023 01:12

Handle all dates as local time, given this all happens in the browser

2ee67ed

Merge branch 'bugfix/get-available-dates-negative-utc-offsets' of git…

6bcf839

…hub.com:calcom/cal.com into bugfix/get-available-dates-negative-utc-offsets

vercel bot had a problem deploying to Preview – ai October 25, 2023 00:13 Failure

vercel bot deployed to Preview – dev October 25, 2023 00:19 View deployment

emrysal requested a review from CarinaWolli October 25, 2023 00:24

emrysal enabled auto-merge (squash) October 25, 2023 00:25

Removed comment

c1c5963

vercel bot had a problem deploying to Preview – ai October 25, 2023 01:07 Failure

vercel bot deployed to Preview – dev October 25, 2023 01:13 View deployment

Add the concept of timezone dependent tests

d919e45

vercel bot had a problem deploying to Preview – ai October 25, 2023 07:28 Failure

vercel bot deployed to Preview – dev October 25, 2023 07:34 View deployment

Fixed broken test

d76a1a6

vercel bot had a problem deploying to Preview – ai October 25, 2023 11:39 Failure

keithwillcode self-requested a review October 25, 2023 11:42

keithwillcode previously approved these changes Oct 25, 2023

View reviewed changes

Fixes timezone dependent tests

db0a11a

emrysal dismissed keithwillcode’s stale review via db0a11a October 25, 2023 11:44

vercel bot had a problem deploying to Preview – ai October 25, 2023 11:45 Failure

vercel bot deployed to Preview – dev October 25, 2023 11:51 View deployment

alishaz-polymath approved these changes Oct 25, 2023

View reviewed changes

emrysal merged commit efc7be0 into main Oct 25, 2023

emrysal deleted the bugfix/get-available-dates-negative-utc-offsets branch October 25, 2023 13:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Infinite loop in timezones on the negative side of UTC #12063

fix: Infinite loop in timezones on the negative side of UTC #12063

emrysal commented Oct 24, 2023

vercel bot commented Oct 24, 2023 •

edited

Loading

github-actions bot commented Oct 24, 2023 •

edited

Loading

github-actions bot commented Oct 24, 2023 •

edited

Loading

deploysentinel bot commented Oct 24, 2023 •

edited

Loading

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

zomars commented Oct 24, 2023

zomars commented Oct 24, 2023

CarinaWolli commented Oct 24, 2023

emrysal commented Oct 24, 2023

alishaz-polymath commented Oct 25, 2023

hariombalhara commented Oct 25, 2023

hariombalhara commented Oct 25, 2023

emrysal commented Oct 25, 2023

keithwillcode left a comment

alishaz-polymath left a comment

fix: Infinite loop in timezones on the negative side of UTC #12063

fix: Infinite loop in timezones on the negative side of UTC #12063

Conversation

emrysal commented Oct 24, 2023

What does this PR do?

vercel bot commented Oct 24, 2023 • edited Loading

github-actions bot commented Oct 24, 2023 • edited Loading

github-actions bot commented Oct 24, 2023 • edited Loading

📦 Next.js Bundle Analysis for @calcom/web

deploysentinel bot commented Oct 24, 2023 • edited Loading

Current Playwright Test Results Summary

⚠️ Flakes

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

zomars commented Oct 24, 2023

zomars commented Oct 24, 2023

CarinaWolli commented Oct 24, 2023

emrysal commented Oct 24, 2023

alishaz-polymath commented Oct 25, 2023

hariombalhara commented Oct 25, 2023

hariombalhara commented Oct 25, 2023

emrysal commented Oct 25, 2023

keithwillcode left a comment

Choose a reason for hiding this comment

alishaz-polymath left a comment

Choose a reason for hiding this comment

vercel bot commented Oct 24, 2023 •

edited

Loading

github-actions bot commented Oct 24, 2023 •

edited

Loading

github-actions bot commented Oct 24, 2023 •

edited

Loading

deploysentinel bot commented Oct 24, 2023 •

edited

Loading