test: api-middleware #11825

sean-brydon · 2023-10-11T11:00:38Z

Adds tests to api middleware

VerifyApiKey
httpMethods
addRequestId
Will add rate limit tests after it has been merged feat: Add rate limting to API #11783

vercel · 2023-10-11T11:00:41Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ai	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 11, 2023 1:27pm
api	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 11, 2023 1:27pm
cal	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Oct 11, 2023 1:27pm
cal-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 11, 2023 1:27pm
dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 11, 2023 1:27pm

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
qa	⬜️ Ignored (Inspect)	Visit Preview		Oct 11, 2023 1:27pm
ui	⬜️ Ignored (Inspect)	Visit Preview		Oct 11, 2023 1:27pm

sean-brydon · 2023-10-11T11:00:50Z

Current dependencies on/for this PR:

main
- PR test: api-middleware #11825 👈

This comment was auto-generated by Graphite.

github-actions · 2023-10-11T11:00:52Z

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

github-actions · 2023-10-11T11:08:16Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

deploysentinel · 2023-10-11T11:09:52Z

Current Playwright Test Results Summary

✅ 147 Passing - ⚠️ 5 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/11/2023 01:30:52pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 4dc5c7b

Started: 10/11/2023 01:28:20pm UTC

⚠️ Flakes

📄 apps/web/playwright/booking-pages.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
pro user can reschedule a booking Retry 2 • Retry 1 • Initial Attempt	1.05% (3) 3 / 285 runs failed over last 7 days	6.67% (19) 19 / 285 runs flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes

Top 1 Common Error Messages

`null`	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme Retry 1 • Initial Attempt	2.80% (8) 8 / 286 runs failed over last 7 days	16.43% (47) 47 / 286 runs flaked over last 7 days
Popup Tests should be able to reschedule Retry 1 • Initial Attempt	4.20% (12) 12 / 286 runs failed over last 7 days	94.41% (270) 270 / 286 runs flaked over last 7 days

📄 apps/web/playwright/managed-event-types.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Managed Event Types tests Can create managed event type Retry 2 • Retry 1 • Initial Attempt	0.70% (2) 2 / 287 runs failed over last 7 days	25.09% (72) 72 / 287 runs flaked over last 7 days

📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Routing Forms Seeded Routing Form Routing Link should validate fields Retry 1 • Initial Attempt	0.35% (1) 1 / 289 run failed over last 7 days	9.69% (28) 28 / 289 runs flaked over last 7 days

View Detailed Build Results

sean-brydon · 2023-10-11T11:28:23Z

.vscode/settings.json

@@ -7,5 +7,6 @@
  "typescript.preferences.importModuleSpecifier": "non-relative",
  "spellright.language": ["en"],
  "spellright.documentTypes": ["markdown", "typescript", "typescriptreact"],
-  "tailwindCSS.experimental.classRegex": [["cva\\(([^)]*)\\)", "[\"'`]([^\"'`]*).*?[\"'`]"]]
+  "tailwindCSS.experimental.classRegex": [["cva\\(([^)]*)\\)", "[\"'`]([^\"'`]*).*?[\"'`]"]],
+  "vitest.commandLine": ""


Suggested change

"vitest.commandLine": ""

sean-brydon · 2023-10-11T11:29:26Z

apps/api/test/lib/bookings/_post.test.ts

Fix tests (These test were never running due to the vitest workspace config)

Commented out so we can still run tests in API dir

sean-brydon · 2023-10-11T11:29:44Z

vitest.workspace.ts

@@ -16,7 +16,7 @@ const workspaces = packagedEmbedTestsOnly
        test: {
          include: ["packages/**/*.{test,spec}.{ts,js}", "apps/**/*.{test,spec}.{ts,js}"],
          // TODO: Ignore the api until tests are fixed
-          exclude: ["apps/api/**/*", "**/node_modules/**/*", "packages/embeds/**/*"],


No longer exclude tests

sean-brydon · 2023-10-11T12:57:37Z

apps/api/test/lib/bookings/_post.test.ts

Fix tests (These test were never running due to the vitest workspace config)

Commented out as they are broken

sean-brydon · 2023-10-11T13:06:40Z

apps/api/test/lib/bookings/_post.test.ts

@@ -21,7 +22,7 @@ vi.mock("@calcom/lib/server/i18n", () => {
  };
 });

-describe("POST /api/bookings", () => {
+describe.skipIf(true)("POST /api/bookings", () => {


Skipping as these tests are always failing - they never used to run due to how vitest.workspace.ts was configured

keithwillcode

Great work, @sean-brydon. What do you think about adding tests for the withMiddleware file as well. This way we can guarantee the middleware we expect to be wired up is there and in the order we expect.

* tests/api-middleware * Skip if true * Remove prisma from response mock

zomars added the core area: core, team members only label Oct 11, 2023

vercel bot deployed to Preview – ai October 11, 2023 11:04 View deployment

vercel bot deployed to Preview – ui October 11, 2023 11:04 View deployment

vercel bot deployed to Preview – api October 11, 2023 11:05 View deployment

vercel bot deployed to Preview – cal-demo October 11, 2023 11:07 View deployment

vercel bot deployed to Preview – dev October 11, 2023 11:10 View deployment

sean-brydon commented Oct 11, 2023

View reviewed changes

sean-brydon force-pushed the 10-11-tests/api-middleware branch from 5775f5d to df1ec3b Compare October 11, 2023 11:28

sean-brydon commented Oct 11, 2023

View reviewed changes

vercel bot deployed to Preview – ai October 11, 2023 11:32 View deployment

vercel bot deployed to Preview – ui October 11, 2023 11:32 View deployment

vercel bot deployed to Preview – api October 11, 2023 11:34 View deployment

vercel bot deployed to Preview – cal-demo October 11, 2023 11:36 View deployment

vercel bot deployed to Preview – dev October 11, 2023 11:36 View deployment

sean-brydon force-pushed the 10-11-tests/api-middleware branch from df1ec3b to 5e5016c Compare October 11, 2023 12:37

vercel bot deployed to Preview – ai October 11, 2023 12:43 View deployment

vercel bot deployed to Preview – ui October 11, 2023 12:44 View deployment

vercel bot deployed to Preview – api October 11, 2023 12:45 View deployment

vercel bot deployed to Preview – dev October 11, 2023 12:46 View deployment

vercel bot deployed to Preview – cal-demo October 11, 2023 12:47 View deployment

tests/api-middleware

a820942

sean-brydon force-pushed the 10-11-tests/api-middleware branch from 5e5016c to a820942 Compare October 11, 2023 12:57

sean-brydon commented Oct 11, 2023

View reviewed changes

sean-brydon marked this pull request as ready for review October 11, 2023 12:58

sean-brydon changed the title ~~tests/api-middleware~~ tests: api-middleware Oct 11, 2023

vercel bot deployed to Preview – ai October 11, 2023 13:00 View deployment

vercel bot deployed to Preview – ui October 11, 2023 13:01 View deployment

vercel bot deployed to Preview – api October 11, 2023 13:02 View deployment

vercel bot deployed to Preview – dev October 11, 2023 13:03 View deployment

Skip if true

030d90b

vercel bot deployed to Preview – cal-demo October 11, 2023 13:04 View deployment

sean-brydon commented Oct 11, 2023

View reviewed changes

vercel bot deployed to Preview – ai October 11, 2023 13:08 View deployment

vercel bot deployed to Preview – api October 11, 2023 13:10 View deployment

vercel bot deployed to Preview – dev October 11, 2023 13:10 View deployment

vercel bot deployed to Preview – cal-demo October 11, 2023 13:12 View deployment

Remove prisma from response mock

4dc5c7b

vercel bot deployed to Preview – ai October 11, 2023 13:23 View deployment

vercel bot deployed to Preview – api October 11, 2023 13:25 View deployment

keithwillcode changed the title ~~tests: api-middleware~~ test: api-middleware Oct 11, 2023

vercel bot deployed to Preview – dev October 11, 2023 13:26 View deployment

vercel bot deployed to Preview – cal-demo October 11, 2023 13:27 View deployment

keithwillcode approved these changes Oct 11, 2023

View reviewed changes

sean-brydon merged commit ce532e0 into main Oct 11, 2023

sean-brydon deleted the 10-11-tests/api-middleware branch October 11, 2023 14:09

zomars pushed a commit that referenced this pull request Oct 11, 2023

test: api-middleware (#11825)

555ae29

* tests/api-middleware * Skip if true * Remove prisma from response mock

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: api-middleware #11825

test: api-middleware #11825

sean-brydon commented Oct 11, 2023 •

edited

Loading

vercel bot commented Oct 11, 2023 •

edited

Loading

sean-brydon commented Oct 11, 2023

github-actions bot commented Oct 11, 2023 •

edited

Loading

github-actions bot commented Oct 11, 2023 •

edited

Loading

deploysentinel bot commented Oct 11, 2023 •

edited

Loading

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Test Case Results

sean-brydon Oct 11, 2023

sean-brydon Oct 11, 2023

sean-brydon Oct 11, 2023

sean-brydon Oct 11, 2023

sean-brydon Oct 11, 2023

keithwillcode left a comment •

edited

Loading

test: api-middleware #11825

test: api-middleware #11825

Conversation

sean-brydon commented Oct 11, 2023 • edited Loading

vercel bot commented Oct 11, 2023 • edited Loading

sean-brydon commented Oct 11, 2023

github-actions bot commented Oct 11, 2023 • edited Loading

github-actions bot commented Oct 11, 2023 • edited Loading

📦 Next.js Bundle Analysis for @calcom/web

deploysentinel bot commented Oct 11, 2023 • edited Loading

Current Playwright Test Results Summary

⚠️ Flakes

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Test Case Results

sean-brydon Oct 11, 2023

Choose a reason for hiding this comment

sean-brydon Oct 11, 2023

Choose a reason for hiding this comment

sean-brydon Oct 11, 2023

Choose a reason for hiding this comment

sean-brydon Oct 11, 2023

Choose a reason for hiding this comment

sean-brydon Oct 11, 2023

Choose a reason for hiding this comment

keithwillcode left a comment • edited Loading

Choose a reason for hiding this comment

sean-brydon commented Oct 11, 2023 •

edited

Loading

vercel bot commented Oct 11, 2023 •

edited

Loading

github-actions bot commented Oct 11, 2023 •

edited

Loading

github-actions bot commented Oct 11, 2023 •

edited

Loading

deploysentinel bot commented Oct 11, 2023 •

edited

Loading

keithwillcode left a comment •

edited

Loading