Issue #608: Add the ability to draw a curve in CalChart #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmpowell77
force-pushed
the
dev/drawing_curves
branch
3 times, most recently
from
1fdc45f to
04e4c8c
Compare
Adding curves to CalChart that are rendered using Catmull-Rom algorithms. Currently backed behind a feature flag. This just adds the ability to draw. They aren't saved as part of the show, nor do marchers interact with them. There is a draw icon and a way to edit their colors in the configuration preference editor. Adding default color for curves when we draw. Added unit tests. You can escape/delete to stop drawing curve.
rmpowell77
force-pushed
the
dev/drawing_curves
branch
from
03bef02 to
316986d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding curves to CalChart that are rendered using Catmull-Rom algorithms. Currently backed behind a feature flag.
This just adds the ability to draw. They aren't saved as part of the show, nor do marchers interact with them. There is a draw icon and a way to edit their colors in the configuration preference editor. Adding default color for curves when we draw.
Added unit tests.