Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #584: Why didn't the failures in ASAN cause sanity_test.py to fail #585

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Issue #584: Why didn't the failures in ASAN cause sanity_test.py to fail #585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions LATEST_RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,6 @@ Bugs addressed in this release:

Other changes:

* [#584](../../issues/584) Why didn't the failures in ASAN cause sanity_test.py to fail?


5 changes: 5 additions & 0 deletions tests/sanity_tester.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,11 @@ def compare_files(file1, file2, custom_comparison_function):
num_errors = 0
line_num = 0
with open(file1, 'r') as f1, open(file2, 'r') as f2:
line_count1 = sum(1 for line in f1)
line_count2 = sum(1 for line in f2)
if (line_count1 != line_count2):
print(f"Failed. Lines {file1}: {line_count1}, {file2}: {line_count2}")
return 1
for line1, line2 in zip(f1, f2):
line_num = line_num + 1
# Apply custom comparison function to each line
Expand Down