This repository has been archived by the owner on May 16, 2023. It is now read-only.
Added an optional feature to enable the url-query feature of the re-exported query_map crate
#120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calavera
reviewed
Oct 10, 2022
aws_lambda_events/Cargo.toml
Outdated
| @@ -75,3 +75,5 @@ rabbitmq = [] | |||
| ses = [] | |||
| streams = [] | |||
| generated = ["activemq", "appsync", "autoscaling", "chime_bot", "clientvpn", "code_commit", "codebuild", "codedeploy", "codepipeline_cloudwatch", "codepipeline_job", "config", "connect", "ecr_scan", "firehose", "iot", "iot_1_click", "iot_button", "kafka", "lambda_function_urls", "lex", "rabbitmq", "ses", "streams"] | |||
|
|
|||
| url-query = ["query_map/url-query"] | |||
There was a problem hiding this comment.
I think this syntax is new. We might not want to use it because people might depend on Rust versions that don't support it yet. I would just add the feature to the query_map dependency.
There was a problem hiding this comment.
I've updated it.
Digging a bit, it looks like that syntax has been supported for quite a while. I found this reference to a fix related to the handling of that part of Cargo.toml in v1.43 (2020-04-23). So it's been supported since sometime prior to that.
There was some new syntax added to that part of Cargo.toml in v1.60, though (dep: and ?).
…-exported `query_map` crate
calavera
approved these changes
Oct 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make things easier in awslabs/aws-lambda-rust-runtime#541.