Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.12.* - Timeout when typing char that does not exist #605

Closed

Conversation

jmoody
Copy link
Contributor

@jmoody jmoody commented Nov 11, 2014

Motivation

This PR addresses #310 and #555 by adding a timeout to uia_type_string; cannot type more than 10 seconds. I added a options :timeout argument to keyboard_enter_text to allow users who need to type exceptionally long pieces of text.

This is 0.12.0 release because it changes keyboard_enter_text public API.

I also added some tests to get a better understanding of these two issues.

@jmoody jmoody added this to the 0.12.* milestone Nov 11, 2014
@jmoody jmoody changed the title Timeout when typing char that does not exist 0.12.* - Timeout when typing char that does not exist Nov 11, 2014
@krukow
Copy link
Contributor

krukow commented Nov 11, 2014

@jmoody I appreciate the effort and initiative to fix this problem, but please don't merge this pull request. It is solving the problem in the wrong place. I would like some time to fix the true cause.

@jmoody
Copy link
Contributor Author

jmoody commented Nov 11, 2014

These are the Scenarios [1] that are hanging indefinitely; they never finish.

They were passing until ~ Nov 5th @ or around the 0.11.4 release or one of the pre-releases.

@issue_310
@keyboard
Feature:  keyboard_enter_text should fail if key does not exist
  In order to catch up on my beauty sleep
  As a calabash developer
  I want uia_type_string to start behaving itself.

  Background: get me to the text tab
    Given I am looking at the Text tab

  Scenario: try type a key that does not exist on text field keyboard
    And one of the text fields has the default keyboard showing
    When I type a key that does not exist it should raise an exception


  Scenario: try type a key that does not exist on text view keyboard
    And one of the text views has the default keyboard showing
    When I type a key that does not exist it should raise an exception

@jmoody
Copy link
Contributor Author

jmoody commented Nov 13, 2014

@krukow
Do you think the timeout on uia_type_string has merit by itself? Regardless of whether you can make a fix at a lower level?

@krukow
Copy link
Contributor

krukow commented Nov 28, 2014

Thanks for the effort and research.

We won't merge this pull request since we can fix the root cause instead (which was a bug in CalabashScript). Fixed with krukow/calabash-script@d7a7f2c

@krukow krukow closed this Nov 28, 2014
@krukow
Copy link
Contributor

krukow commented Nov 29, 2014

Should be fixed in 0.11.5.pre3 - #630

Please reopen if you see fit.

@jmoody jmoody deleted the feature/timeout-when-typing-char-that-does-not-exist branch January 7, 2015 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants