ntd: recast ntd_id as string #3704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlie-costanzo
added
the
data-pipeline-ingestion-and-modeling
|
Warehouse report 📦 DAGLegend (in order of precedence)
|
charlie-costanzo
requested review from
evansiroky,
vevetron and
tiffanychu90
as code owners
vevetron
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When bringing in new NTD data endpoints, many instances of
ntd_idwere cast as float/int instead of the string. This PR corrects the typecasting to improve usability when joining across tablesResolves #3683
Type of change
How has this been tested?
Post-merge follow-ups