Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched out the default image for 2025.1.15, keeps older image #3690

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

vevetron
Copy link
Contributor

Switched out the default image for 2025.1.15, keeps older image

Description

It appears the 2025.1.15 image which uses python 3.11 is well accepted by the analytics team, will make it to default. We can keep the older image (it's only 2 GB). Also the power user will also use the default image now.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

How has this been tested?

Not tested.

Post-merge follow-ups

  • No action required
  • Actions required (specified below)
    Just make sure jupyterhub is okay today.

@vevetron vevetron marked this pull request as ready for review February 12, 2025 21:44
@vevetron vevetron requested a review from evansiroky as a code owner February 12, 2025 21:44
@tiffanychu90 tiffanychu90 self-requested a review February 12, 2025 21:46
Copy link

The following changes will be applied to the production Kubernetes cluster upon merge.

BE AWARE this may not reveal changes that have been manually applied to the cluster getting undone—applying manual changes to the cluster should be avoided.

jupyterhub, continuous-image-puller, DaemonSet (apps) has changed:
...
            securityContext:
              allowPrivilegeEscalation: false
              runAsGroup: 65534
              runAsUser: 65534
          - name: image-pull-singleuser
-           image: ghcr.io/cal-itp/data-infra/jupyter-singleuser:2024.3.27
+           image: ghcr.io/cal-itp/data-infra/jupyter-singleuser:2025.1.15
            command:
              - /bin/sh
              - -c
              - echo "Pulling complete"
            securityContext:
              allowPrivilegeEscalation: false
              runAsGroup: 65534
              runAsUser: 65534
          - name: image-pull-singleuser-profilelist-2
-           image: ghcr.io/cal-itp/data-infra/jupyter-singleuser:2025.1.15
+           image: ghcr.io/cal-itp/data-infra/jupyter-singleuser:2024.3.27
            command:
              - /bin/sh
              - -c
              - echo "Pulling complete"
            securityContext:
...
jupyterhub, hub, ConfigMap (v1) has changed:
...
          configuration item if not None
          """
          data = get_config(key)
          if data is not None:
              setattr(cparent, name, data)
-   checksum_hook-image-puller: "dfaae06b433797f1c748168b8e8895bcdd82a090cd0f35f18adbfa8bccb7b314"
+   checksum_hook-image-puller: "f1bbdb8e153dba2ccb4acad437eb79ca814dac3306e255bd503b8c00a8ca1d04"
jupyterhub, hub, Deployment (apps) has changed:
...
          release: jupyterhub
          hub.jupyter.org/network-access-proxy-api: "true"
          hub.jupyter.org/network-access-proxy-http: "true"
          hub.jupyter.org/network-access-singleuser: "true"
        annotations:
-         checksum/config-map: 7c7495c176705158a532559aaadc83751da2553a6dc8af74af20a3fe1ffdd44c
-         checksum/secret: aacb3f68f8788860d12943aa39c7b1814f204279d2ab5708dac73d596754b381
+         checksum/config-map: 4382487804ba175886bda74955ad5a72010e8d5c2d1410ad7db2fffe93fa1003
+         checksum/secret: eb4e6aee688ed69fcd8b9f0935a61a611408299de8be02920d9848cc744c7461
      spec:
        tolerations:
          - effect: NoSchedule
            key: hub.jupyter.org/dedicated
            operator: Equal
...
jupyterhub, hub, Secret (v1) has changed:
...
    name: hub
  data:
    hub.config.ConfigurableHTTPProxy.auth_token: 'REDACTED # (64 bytes)'
    hub.config.CryptKeeper.keys: 'REDACTED # (64 bytes)'
    hub.config.JupyterHub.cookie_secret: 'REDACTED # (64 bytes)'
-   values.yaml: '-------- # (11767 bytes)'
+   values.yaml: '++++++++ # (11829 bytes)'
  type: Opaque

Copy link
Member

@tiffanychu90 tiffanychu90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vevetron vevetron merged commit f318c9b into main Feb 12, 2025
2 checks passed
@vevetron vevetron deleted the update_singleuser_images branch February 12, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants