Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted jupyterhub config name to match documentation #3642

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

vevetron
Copy link
Contributor

@vevetron vevetron commented Jan 9, 2025

Description

Adjusted the jupyterhub config docker / tag names to match the website

Follows https://z2jh.jupyter.org/en/latest/jupyterhub/customizing/user-environment.html#multiple-profiles

Meant to fix #3614

Resolves #3615

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • [] New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

How has this been tested?

Has not been tested

Post-merge follow-ups

  • No action required
  • Actions required (specified below)
    Deploy and monitor

@vevetron vevetron requested a review from evansiroky as a code owner January 9, 2025 21:40
@vevetron vevetron force-pushed the test_jupyterhub_images branch from b69e843 to d0be8ec Compare January 9, 2025 21:41
Copy link

github-actions bot commented Jan 9, 2025

The following changes will be applied to the production Kubernetes cluster upon merge.

BE AWARE this may not reveal changes that have been manually applied to the cluster getting undone—applying manual changes to the cluster should be avoided.

jupyterhub, continuous-image-puller, DaemonSet (apps) has changed:
...
            securityContext:
              allowPrivilegeEscalation: false
              runAsGroup: 65534
              runAsUser: 65534
          - name: image-pull-singleuser-profilelist-2
-           image: map[name:ghcr.io/cal-itp/data-infra/jupyter-singleuser tag:2024.5.24]
+           image: ghcr.io/cal-itp/data-infra/jupyter-singleuser:2024.5.24
            command:
              - /bin/sh
              - -c
              - echo "Pulling complete"
            securityContext:
...
jupyterhub, hub, ConfigMap (v1) has changed:
...
          configuration item if not None
          """
          data = get_config(key)
          if data is not None:
              setattr(cparent, name, data)
-   checksum_hook-image-puller: "e4c19a522db5261d6dd8a509b8678a795ac4d27da120f36f80fd99bfbd77b5be"
+   checksum_hook-image-puller: "ea587a740bd8c6376ee7f4a41b3f5957f4d23a103fb0714fecad1b2be3105cae"
jupyterhub, hub, Deployment (apps) has changed:
...
          release: jupyterhub
          hub.jupyter.org/network-access-proxy-api: "true"
          hub.jupyter.org/network-access-proxy-http: "true"
          hub.jupyter.org/network-access-singleuser: "true"
        annotations:
-         checksum/config-map: 4caea480dd83b11f0740df7b74391fe54d311bcf8ebf2b78b435ae7b6187bc6e
-         checksum/secret: 575940346b9c7439fd97115473ed32c772bde3185fbe26074c0b32f4a718bf75
+         checksum/config-map: 5b4f7fe1a41155daf1093411c656925022a4aec125cf1f158fd7122051c2110e
+         checksum/secret: a9f021f09c0b3d24b30aa72740ae1983768e7cecdd044c0b5c583afb5028b4e2
      spec:
        tolerations:
          - effect: NoSchedule
            key: hub.jupyter.org/dedicated
            operator: Equal
...
jupyterhub, hub, Secret (v1) has changed:
...
    name: hub
  data:
    hub.config.ConfigurableHTTPProxy.auth_token: 'REDACTED # (64 bytes)'
    hub.config.CryptKeeper.keys: 'REDACTED # (64 bytes)'
    hub.config.JupyterHub.cookie_secret: 'REDACTED # (64 bytes)'
-   values.yaml: '-------- # (11783 bytes)'
+   values.yaml: '++++++++ # (11754 bytes)'
  type: Opaque

@vevetron vevetron merged commit 822f76f into main Jan 9, 2025
2 checks passed
@vevetron vevetron deleted the test_jupyterhub_images branch January 9, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Jupyterhub server deployment fails
2 participants