Update criteria used to deploy package list changes to Composer #3217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlie-costanzo
approved these changes
Jan 5, 2024
SorenSpicknall
deleted the
soren-update_composer_packages_deploy_criteria
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It appears that changes to /airflow/requirements.txt weren't making their way to Composer's PyPI package list automatically because
deploy-airflow.ymlused an incorrect rule formulation to detect relevant merges to main. This should resolve the issue.Resolves #3215
Type of change
How has this been tested?
This can't be fully tested until merge. Upon merge, the
changed-requirementstask in the Airflow deployment CI workflow should fire, and then the next task should be skipped because the requirements list isn't changed by this PR. Seeing the first task fire will be enough to determine that the deployment bug has been fixed.Post-merge follow-ups
Monitor the CI run upon merge to ensure behavior is as expected.