Add pydantic 1.9 to Composer PyPI Packages #3216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlie-costanzo
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we upgraded to use pyairtable V2 in our Composer PyPI package list for auth reasons, it introduced a dependency conflict: pyairtable has a version-unbounded pydantic requirement that in turn brings in typing-extensions. Because the pydantic version being fetched relied on a newer version of typing-extensions than the one that comes with our Composer-Airflow instance (which we can't modify), we need to pin the pydantic version imported in Composer to avoid the conflict. I used 1.9, which is used elsewhere in
data-infra.Merging this PR will also conveniently allow us to test some additional current behavior related to #3215 - does the Action fail to run when a new package is added to the requirements list, or just when the package version numbers are changed?
Type of change
How has this been tested?
Tested via rollout on production Composer - a safe move because Composer automatically rejects changes that produce dependency conflicts, rather than getting into a bad state.
Post-merge follow-ups
Monitor merge CI behavior to continue investigating #3215.