Added saving column's comment for PostgresAdapter when you add column

[Rymmugygr]

No description provided.

[codecov-io]

Codecov Report

Merging #1246 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1246      +/-   ##
==========================================
+ Coverage   72.32%   72.34%   +0.01%     
==========================================
  Files          35       35              
  Lines        5551     5554       +3     
==========================================
+ Hits         4015     4018       +3     
  Misses       1536     1536

Impacted Files	Coverage Δ
src/Phinx/Db/Adapter/PostgresAdapter.php	92.7% <100%> (+0.03%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 454238f...dd20ad6. Read the comment docs.

[chinpei215]

I think this should be done in the getColumnSqlDefinition() method, like MysqlAdapter:

phinx/src/Phinx/Db/Adapter/MysqlAdapter.php

Lines 1005 to 1007 in d84a6c7

	if ($column->getComment()) {
	$def .= ' COMMENT ' . $this->getConnection()->quote($column->getComment());
	}

and SQLiteAdapter:

phinx/src/Phinx/Db/Adapter/SQLiteAdapter.php

Line 995 in d84a6c7

$def .= $this->getCommentDefinition($column);

[Rymmugygr]

The problem is that PostgreSQL requires additional (separate) request for adding a comment for a column.

For example:

• MySQL: "ALTER TABLE books ADD COLUMN author int(10) unsigned NOT NULL COMMENT 'a new comment';"
• PostgreSQL: "ALTER TABLE books ADD COLUMN author int NOT NULL;" + "COMMENT ON COLUMN books.author IS 'a new comment';"

If we add this logic into getColumnSqlDefinition() its behavior will be much different from the same methods in other adapters.

Comments treated this way in other methods, for example, createTable() adds comments only after column definitions:

phinx/src/Phinx/Db/Adapter/PostgresAdapter.php

Lines 201 to 208 in d84a6c7

	foreach ($columns as $column) {
	$sql .= $this->quoteColumnName($column->getName()) . ' ' . $this->getColumnSqlDefinition($column) . ', ';
	// set column comments, if needed
	if ($column->getComment()) {
	$this->columnsWithComments[] = $column;
	}
	}

[chinpei215]

Thank you for the explanation. You are right.