Add tests for ordered seeds

cakephp · Nov 26, 2017 · bc9fe48 · bc9fe48
1 parent b7b9ac9
commit bc9fe48
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 3 deletions.
diff --git a/src/Phinx/Migration/Manager.php b/src/Phinx/Migration/Manager.php
@@ -772,7 +772,7 @@ public function setSeeds(array $seeds)
     /**
      * Get seed dependencies instances from seed dependency array
      *
-     * @param OrderedSeedInterface $seed
+     * @param OrderedSeedInterface $seed Seed
      *
      * @return AbstractSeed[]
      */
@@ -791,13 +791,14 @@ protected function getSeedDependenciesInstances(OrderedSeedInterface $seed)
                 }
             }
         }
+
         return $dependenciesInstances;
     }
 
     /**
      * Order seeds by dependencies
      *
-     * @param AbstractSeed[] $seeds
+     * @param AbstractSeed[] $seeds Seeds
      *
      * @return AbstractSeed[]
      */
@@ -816,6 +817,7 @@ protected function orderSeedsByDependencies(array $seeds)
                 $orderedSeeds[$key] = $seed;
             }
         }
+
         return $orderedSeeds;
     }
 

diff --git a/tests/Phinx/Migration/ManagerTest.php b/tests/Phinx/Migration/ManagerTest.php
@@ -5406,6 +5406,14 @@ public function testExecuteANonExistentSeedWorksAsExpectedWithMixedNamespace()
         $this->assertContains('Foo\Bar\UserSeeder', $output);
     }
 
+    public function testOrderSeeds()
+    {
+        $seeds = array_values($this->manager->getSeeds());
+        $this->assertInstanceOf('UserSeeder', $seeds[0]);
+        $this->assertInstanceOf('GSeeder', $seeds[1]);
+        $this->assertInstanceOf('PostSeeder', $seeds[2]);
+    }
+
     public function testGettingInputObject()
     {
         $migrations = $this->manager->getMigrations();

diff --git a/tests/Phinx/Migration/_files/seeds/PostSeeder.php b/tests/Phinx/Migration/_files/seeds/PostSeeder.php
@@ -1,8 +1,9 @@
 <?php
 
 use Phinx\Seed\AbstractSeed;
+use Phinx\Seed\OrderedSeedInterface;
 
-class PostSeeder extends AbstractSeed
+class PostSeeder extends AbstractSeed implements OrderedSeedInterface
 {
     public function run()
     {
@@ -21,4 +22,12 @@ public function run()
         $posts->insert($data)
               ->save();
     }
+
+    public function getDependencies()
+    {
+        return [
+            'UserSeeder',
+            'GSeeder',
+        ];
+    }
 }