add case sensitivity testing

cakephp · Dec 26, 2023 · 2909829 · 2909829
1 parent 875c2fd
commit 2909829
Show file tree

Hide file tree

Showing 6 changed files with 46 additions and 10 deletions.
diff --git a/src/Phinx/Db/Adapter/PostgresAdapter.php b/src/Phinx/Db/Adapter/PostgresAdapter.php
@@ -870,11 +870,7 @@ public function hasPrimaryKey(string $tableName, $columns, ?string $constraint =
             return $primaryKey['constraint'] === $constraint;
         }
 
-        // Normalize the columns for comparison
-        $primaryKeyColumns = array_map('mb_strtolower', $primaryKey['columns']);
-        $columns = array_map('mb_strtolower', (array)$columns);
-
-        return $primaryKeyColumns === $columns;
+        return $primaryKey['columns'] === (array)$columns;
     }
 
     /**

diff --git a/src/Phinx/Db/Adapter/SqlServerAdapter.php b/src/Phinx/Db/Adapter/SqlServerAdapter.php
@@ -894,11 +894,7 @@ public function hasPrimaryKey(string $tableName, $columns, ?string $constraint =
             return $primaryKey['constraint'] === $constraint;
         }
 
-        // Normalize the columns for comparison
-        $primaryKeyColumns = array_map('mb_strtolower', $primaryKey['columns']);
-        $columns = array_map('mb_strtolower', (array)$columns);
-
-        return $primaryKeyColumns === $columns;
+        return $primaryKey['columns'] === (array)$columns;
     }
 
     /**

diff --git a/tests/Phinx/Db/Adapter/MysqlAdapterTest.php b/tests/Phinx/Db/Adapter/MysqlAdapterTest.php
@@ -587,6 +587,17 @@ public function testHasPrimaryKeyMultipleColumns()
         $this->assertFalse($table->hasPrimaryKey(['column1', 'column2', 'column3', 'column4']));
     }
 
+    public function testHasPrimaryKeyCaseInsensitivity()
+    {
+        $table = new Table('table', ['id' => false, 'primary_key' => ['column1']], $this->adapter);
+        $table
+            ->addColumn('column1', 'integer', ['null' => false])
+            ->save();
+
+        $this->assertTrue($table->hasPrimaryKey('column1'));
+        $this->assertTrue($table->hasPrimaryKey('cOlUmN1'));
+    }
+
     public function testAddComment()
     {
         $table = new Table('table1', [], $this->adapter);

diff --git a/tests/Phinx/Db/Adapter/PostgresAdapterTest.php b/tests/Phinx/Db/Adapter/PostgresAdapterTest.php
@@ -446,6 +446,17 @@ public function testHasPrimaryKeyMultipleColumns()
         $this->assertFalse($table->hasPrimaryKey(['column1', 'column2', 'column3', 'column4']));
     }
 
+    public function testHasPrimaryKeyCaseSensitivity()
+    {
+        $table = new Table('table', ['id' => false, 'primary_key' => ['column1']], $this->adapter);
+        $table
+            ->addColumn('column1', 'integer', ['null' => false])
+            ->save();
+
+        $this->assertTrue($table->hasPrimaryKey('column1'));
+        $this->assertFalse($table->hasPrimaryKey('cOlUmN1'));
+    }
+
     public function testAddComment()
     {
         $table = new Table('table1', [], $this->adapter);

diff --git a/tests/Phinx/Db/Adapter/SQLiteAdapterTest.php b/tests/Phinx/Db/Adapter/SQLiteAdapterTest.php
@@ -429,6 +429,17 @@ public function testHasPrimaryKeyMultipleColumns()
         $this->assertFalse($table->hasPrimaryKey(['column1', 'column2', 'column3', 'column4']));
     }
 
+    public function testHasPrimaryKeyCaseInsensitivity()
+    {
+        $table = new Table('table', ['id' => false, 'primary_key' => ['column1']], $this->adapter);
+        $table
+            ->addColumn('column1', 'integer', ['null' => false])
+            ->save();
+
+        $this->assertTrue($table->hasPrimaryKey('column1'));
+        $this->assertTrue($table->hasPrimaryKey('cOlUmN1'));
+    }
+
     public function testAddMultipleColumnPrimaryKeyFails()
     {
         $table = new Table('table1', [], $this->adapter);

diff --git a/tests/Phinx/Db/Adapter/SqlServerAdapterTest.php b/tests/Phinx/Db/Adapter/SqlServerAdapterTest.php
@@ -372,6 +372,17 @@ public function testHasPrimaryKeyMultipleColumns()
         $this->assertFalse($table->hasPrimaryKey(['column1', 'column2', 'column3', 'column4']));
     }
 
+    public function testHasPrimaryKeyCaseSensitivity()
+    {
+        $table = new Table('table', ['id' => false, 'primary_key' => ['column1']], $this->adapter);
+        $table
+            ->addColumn('column1', 'integer', ['null' => false])
+            ->save();
+
+        $this->assertTrue($table->hasPrimaryKey('column1'));
+        $this->assertFalse($table->hasPrimaryKey('cOlUmN1'));
+    }
+
     public function testChangeCommentFails()
     {
         $table = new Table('table1', [], $this->adapter);