-
-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implicit bootstrapping of modules #2833
Comments
@cake-build/cake-team switching this to a breaking change, since we are removing the |
@gep13 @cake-build/cake-team Not sure if I would call it a breaking change. |
This isn't a breaking change, just tried to build Cake with cake using 1.0.0-GH-2833-0001 in a clean repo, and it runs & "$CakeExePath" ./build.cake --bootstrap
if ($LASTEXITCODE -eq 0)
{
& "$CakeExePath" ./build.cake $args
}
exit $LASTEXITCODE |
@devlead did it run the build twice? If so, if it isn't a breaking change, then it should be a breaking change. |
so this:
Is a no-op? If the bootstrap option is being removed, how is it doing this? If I misread the PR when I had a brief look at it, I apologise. |
Ah no your correct, but that should be corrected in the PR imho, I'll give that feedback on PR. |
As a side note, the same would be true for cake-build/cake-action. Existing workflows can still pass the |
Wouldn't it make sense for & "$CakeExePath" ./build.cake --bootstrap
# Does nothing, displays an info message explaining --bootstrap is no longer needed
# Returns 0 in exit code to let the script to continue
if ($LASTEXITCODE -eq 0)
{
& "$CakeExePath" ./build.cake $args
}
exit $LASTEXITCODE |
It's not a noop in the current PR or works as previously. So no breaking change there. Only difference is that it'll also run implicitly without extra step when you execute scripts unless you opt out. |
Got it. Thanks. So only the bootstrap process would run twice in the scenario above. |
🎉 This issue has been resolved in version v1.0.0 🎉 The release is available on: Your GitReleaseManager bot 📦🚀 |
Currently, when using Cake Modules, if it first necessary to do something like the following:
To force Cake to first check and download any Modules that are included within the Cake Script, and then you run the build as normal:
This is a minor change to the default bootstrapper to make this happen, however, it would be very nice, if possible, that Cake implicitly did this check and download for any modules added to the Cake, so that it is a single execution of Cake.
The text was updated successfully, but these errors were encountered: