Added support for custom default directory to sync CreamAssets #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricWiener
changed the title
|
Sorry please ignore the closing and re-opening ^ |
EricWiener
force-pushed
the
master
branch
3 times, most recently
from
f837020 to
a284bd2
Compare
Added a static property creamAssetURL to CreamAsset that lets the user specify the directory that they want to store CreamAssets in. creamAssetDefaultURL will default to using creamAssetURL if specified. If it is not specified, it will behave as usual (backwards compatible).
Added example showing where to specify the directory to use and discussed the reasons why you would want to do this, namely App Groups.
Previous modification returned the user specified URL right away without using file manager to make sure that all intermediate directories existed. Modified this to use the user specified URL if it existed, but to also make sure that this was a valid path.
…d primary key Bug: the app would crash if a primary key was used that had an emoji in it. This was an issue for my app because the app accidentally used an emoji in a primary key if the user chose to include an emoji in the title of something. Fix: removed all emojis from the primary key if they existed. This was enough to allow me to remove the error when saving primary keys and allow existing users to continue to use their iCloud without resetting their cached data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a static property to
CreamAssetto allow changing the default directory to save CreamAssets too. This is needed if you want to use App Groups and need to use the shared directory instead of the default documents directory. Fully backward compatible and added usage to the README.