Remove extra variable in BlockSearch (cosmos#280)

caelus-labs · Feb 9, 2022 · 1a42c63 · 1a42c63
1 parent 566d728
commit 1a42c63
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/CHANGELOG-PENDING.md b/CHANGELOG-PENDING.md
@@ -25,6 +25,7 @@ Month, DD, YYYY
 - [rpc] [Implement ConsensusState/DumpConsensusState #273](https://github.com/celestiaorg/optimint/pull/273) [@tzdybal](https://github.com/tzdybal/)
 - [rpc] [Implement Tx Method #272](https://github.com/celestiaorg/optimint/pull/272) [@mauriceLC92](https://github.com/mauriceLC92)
 - [rpc] [Implement Commit and BlockSearch method #258](https://github.com/celestiaorg/optimint/pull/258) [@raneet10](https://github.com/Raneet10/)
+- [rpc] [Remove extra variable #280](https://github.com/celestiaorg/optimint/pull/280) [@raneet10](https://github.com/Raneet10/)
 
 ### BUG FIXES
 

diff --git a/rpc/client/client.go b/rpc/client/client.go
@@ -545,13 +545,10 @@ func (c *Client) BlockSearch(ctx context.Context, query string, page, perPage *i
 	skipCount := validateSkipCount(pageVal, perPageVal)
 	pageSize := tmmath.MinInt(perPageVal, totalCount-skipCount)
 
-	pageResults := make([]int64, pageSize)
-	copy(pageResults, results[skipCount:skipCount+pageSize])
-
 	// Fetch the blocks
-	blocks := make([]*ctypes.ResultBlock, 0, len(pageResults))
-	for _, h := range pageResults {
-		b, err := c.node.Store.LoadBlock(uint64(h))
+	blocks := make([]*ctypes.ResultBlock, 0, pageSize)
+	for i := skipCount; i < skipCount+pageSize; i++ {
+		b, err := c.node.Store.LoadBlock(uint64(results[i]))
 		if err != nil {
 			return nil, err
 		}