Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yarpc error code 13 should not be retriable #958

Merged
merged 2 commits into from
Jul 12, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/util.go
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ func IsWhitelistServiceTransientError(err error) bool {
return true
case *yarpcerrors.Status:
// We only selectively retry the following yarpc errors client can safe retry with a backoff
if yarpcerrors.IsDeadlineExceeded(err) || yarpcerrors.IsUnavailable(err) || yarpcerrors.IsInternal(err) {
if yarpcerrors.IsDeadlineExceeded(err) || yarpcerrors.IsUnavailable(err) {
return true
}
return false
Expand Down