Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test to ensure dynamic config key has mapped value #922

Merged
merged 2 commits into from
Jul 3, 2018
Merged

Add test to ensure dynamic config key has mapped value #922

merged 2 commits into from
Jul 3, 2018

Conversation

vancexu
Copy link
Contributor

@vancexu vancexu commented Jul 3, 2018 •
edited
Loading

This will ensure people who add new configs won't forget to put the real key value

@vancexu vancexu requested a review from wxing1292 July 3, 2018 20:51
@vancexu vancexu requested a review from samarabbas July 3, 2018 21:03
@vancexu vancexu merged commit 57e8196 into master Jul 3, 2018
@vancexu vancexu deleted the config branch July 3, 2018 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxing1292 wxing1292 wxing1292 approved these changes

@samarabbas samarabbas Awaiting requested review from samarabbas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vancexu @wxing1292