Implement ListDomain API #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
reviewed
Jun 22, 2018
| return nil, wh.error(errRequestNotSet, scope) | ||
| } | ||
|
|
||
| pageSize := 100 |
There was a problem hiding this comment.
care to make this configurable? in the service.go file
There was a problem hiding this comment.
I would suggest not to use config file for this number unless you really need it.
- User can always pass in a pageSize in the API. That would be the most use cases.
- It is not necessary that we have to use different default page size in different environment(staging/sjc/dca/autobots/public repo/etc)
- Having config will add more code and more configs, which would introduce lots of unnecessary code/config(staging/sjc/dca/autobots/public repo/etc).
- If having it in config, we still need to verify if the config value is set or not. If not, do you want to exit the process? Or use a another default value from code? Both look unnecessary.
I am trying to understand why you want this. If this hardcoding number bothers you, I think we can use a constant number defined on the top of the file or somewhere else.
There was a problem hiding this comment.
if you take a look at the service.go file or at least the top of the file you are changing, you can see a lot of const, which makes it easy to manage.
defining a arbitrary number everywhere in the code is not a good practice.
samarabbas
reviewed
Jun 22, 2018
| @@ -802,8 +802,18 @@ struct RegisterDomainRequest { | |||
| 80: optional map<string,string> data | |||
| } | |||
|
|
|||
| struct ListDomainRequest { | |||
| 10: optional i32 pageSize | |||
| 20: optional string nextPageToken | |||
There was a problem hiding this comment.
Can you binary blob for nextPageToken.
samarabbas
reviewed
Jun 22, 2018
samarabbas
approved these changes
Jun 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.