Backoff on shard creation and adjust default number of persistence conns #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shard creation happens on start of each history service host. So if we have large number of history hosts then we could overwhelm the cluster. This change puts in a backoff shard creation and also update the logic to only create shards if neccessary by doing a get first. Also adjusted the default number of persistence connection for history and execution manger to 50.
wxing1292
approved these changes
Jun 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shard creation happens on start of each history service host. So if we
have large number of history hosts then we could overwhelm the cluster.
This change puts in a backoff shard creation and also update the logic
to only create shards if neccessary by doing a get first.
Also adjusted the default number of persistence connection for history
and execution manger to 50.