Add CLI show workflow progress #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfateev
reviewed
Apr 5, 2018
| printWorkflowProgress(c, wid, resp.GetRunId()) | ||
| } | ||
|
|
||
| // helper function to print workflow progress with time refresh every second |
There was a problem hiding this comment.
I'm confused about the refresh every second. Why do we need to set timeout to one second for long poll? Wouldn't it return immediately if there is a new information even with a large timeout?
There was a problem hiding this comment.
This is just for UI purpose. We want to give user a feeling something is still running even when there is no new history comming. So currently UI dynamically show elapsed time in seconds and the number change every second.
mfateev
approved these changes
Apr 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.