Add schedule id to pending activity info and pending decision info to history service #6507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fimanishi
force-pushed
the
add-scheduleID-to-pendingActivityInfo-and-pendingDecisionInfo-to-history-service
branch
from
6d070d5 to
12a2224
Compare
fimanishi
force-pushed
the
add-scheduleID-to-pendingActivityInfo-and-pendingDecisionInfo-to-history-service
branch
from
ffdbb6a to
ce51697
Compare
fimanishi
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Shaddoll
approved these changes
Nov 20, 2024
abhishekj720
approved these changes
Nov 20, 2024
taylanisikdemir
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added scheduleID to PendingActivityInfo and PendingDecisionInfo to the history service
Why?
Added scheduleID to pendingActivityInfo and PendingDecisionInfo in idls
How did you test it?
Unit tests
Potential risks
This is just adding a field, it's not a breaking change
Release notes
ScheduleID for decision and activity tasks now available in PendingActivityInfo and PendingDecisionInfo
Documentation Changes