Adding more tests to admin_commands #6475
Conversation
Same way as existing table-tests
dkrotx
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
taylanisikdemir and
demirkayaender
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| @@ -61,6 +61,15 @@ func BoolArgument(name string, value bool) CliArgument { | |||
| } | |||
| } | |||
|
|
|||
| // Int64Argument introduces a new int64 argument for cli context | |||
| func Int64Argument(name string, value int64) CliArgument { | |||
There was a problem hiding this comment.
Maybe we could just do this with generics? I see they have GenericFlag, but I dunno how easy it is to use.
There was a problem hiding this comment.
Hmm... that's true. At the same time, lots of those are just const-s, and then you have to convert them to types explicitly anyway.
What changed?
Added more tests of admin_commands
Why?
Unit-test coverage
How did you test it?
Potential risks
Release notes
Documentation Changes