Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for serialization package #6420

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Add unit tests for serialization package #6420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions common/persistence/serialization/thrift_mapper_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ func TestShardInfo(t *testing.T) {
assert.Contains(t, actual.ClusterTimerAckLevel, "key_2")
assert.Equal(t, expected.ClusterTimerAckLevel["key_1"].Sub(actual.ClusterTimerAckLevel["key_1"]), time.Duration(0))
assert.Equal(t, expected.ClusterTimerAckLevel["key_2"].Sub(actual.ClusterTimerAckLevel["key_2"]), time.Duration(0))
assert.Nil(t, shardInfoFromThrift(nil))
assert.Nil(t, shardInfoToThrift(nil))
}

func TestDomainInfo(t *testing.T) {
Expand Down Expand Up @@ -129,6 +131,8 @@ func TestDomainInfo(t *testing.T) {
assert.Equal(t, expected.FailoverEndTimestamp.Sub(*actual.FailoverEndTimestamp), time.Duration(0))
assert.Equal(t, expected.PreviousFailoverVersion, actual.PreviousFailoverVersion)
assert.Equal(t, expected.LastUpdatedTimestamp.Sub(actual.LastUpdatedTimestamp), time.Duration(0))
assert.Nil(t, domainInfoFromThrift(nil))
assert.Nil(t, domainInfoToThrift(nil))
}

func TestDomainInfoRoundtripPanictest(t *testing.T) {
Expand All @@ -138,6 +142,9 @@ func TestDomainInfoRoundtripPanictest(t *testing.T) {
"empty roundtrip": {
in: &DomainInfo{},
},
"nil roundtrip": {
in: nil,
},
}

for name, td := range tests {
Expand Down Expand Up @@ -168,6 +175,8 @@ func TestHistoryTreeInfo(t *testing.T) {
assert.Equal(t, expected.CreatedTimestamp.Sub(actual.CreatedTimestamp), time.Duration(0))
assert.Equal(t, expected.Ancestors, actual.Ancestors)
assert.Equal(t, expected.Info, actual.Info)
assert.Nil(t, historyTreeInfoFromThrift(nil))
assert.Nil(t, historyTreeInfoToThrift(nil))
}

func TestWorkflowExecutionInfo(t *testing.T) {
Expand Down Expand Up @@ -297,6 +306,8 @@ func TestWorkflowExecutionInfo(t *testing.T) {
assert.Equal(t, expected.PartitionConfig, actual.PartitionConfig)
assert.Equal(t, expected.Checksum, actual.Checksum)
assert.Equal(t, expected.ChecksumEncoding, actual.ChecksumEncoding)
assert.Nil(t, workflowExecutionInfoFromThrift(nil))
assert.Nil(t, workflowExecutionInfoToThrift(nil))
}

func TestActivityInfo(t *testing.T) {
Expand Down Expand Up @@ -365,6 +376,8 @@ func TestActivityInfo(t *testing.T) {
assert.Equal(t, expected.ScheduledTimestamp.Sub(actual.ScheduledTimestamp), time.Duration(0))
assert.Equal(t, expected.StartedTimestamp.Sub(actual.StartedTimestamp), time.Duration(0))
assert.Equal(t, expected.RetryExpirationTimestamp.Sub(actual.RetryExpirationTimestamp), time.Duration(0))
assert.Nil(t, activityInfoFromThrift(nil))
assert.Nil(t, activityInfoToThrift(nil))
}

func TestChildExecutionInfo(t *testing.T) {
Expand All @@ -386,6 +399,8 @@ func TestChildExecutionInfo(t *testing.T) {
}
actual := childExecutionInfoFromThrift(childExecutionInfoToThrift(expected))
assert.Equal(t, expected, actual)
assert.Nil(t, childExecutionInfoFromThrift(nil))
assert.Nil(t, childExecutionInfoToThrift(nil))
}

func TestSignalInfo(t *testing.T) {
Expand All @@ -399,6 +414,8 @@ func TestSignalInfo(t *testing.T) {
}
actual := signalInfoFromThrift(signalInfoToThrift(expected))
assert.Equal(t, expected, actual)
assert.Nil(t, signalInfoFromThrift(nil))
assert.Nil(t, signalInfoToThrift(nil))
}

func TestRequestCancelInfo(t *testing.T) {
Expand All @@ -409,6 +426,8 @@ func TestRequestCancelInfo(t *testing.T) {
}
actual := requestCancelInfoFromThrift(requestCancelInfoToThrift(expected))
assert.Equal(t, expected, actual)
assert.Nil(t, requestCancelInfoFromThrift(nil))
assert.Nil(t, requestCancelInfoToThrift(nil))
}

func TestTimerInfo(t *testing.T) {
Expand All @@ -423,6 +442,8 @@ func TestTimerInfo(t *testing.T) {
assert.Equal(t, expected.StartedID, actual.StartedID)
assert.Equal(t, expected.TaskID, actual.TaskID)
assert.Equal(t, expected.ExpiryTimestamp.Sub(actual.ExpiryTimestamp), time.Duration(0))
assert.Nil(t, timerInfoFromThrift(nil))
assert.Nil(t, timerInfoToThrift(nil))
}

func TestTaskInfo(t *testing.T) {
Expand All @@ -441,6 +462,8 @@ func TestTaskInfo(t *testing.T) {
assert.Equal(t, expected.ExpiryTimestamp.Sub(actual.ExpiryTimestamp), time.Duration(0))
assert.Equal(t, expected.CreatedTimestamp.Sub(actual.CreatedTimestamp), time.Duration(0))
assert.Equal(t, expected.PartitionConfig, actual.PartitionConfig)
assert.Nil(t, taskInfoFromThrift(nil))
assert.Nil(t, taskInfoToThrift(nil))
}

func TestTaskListInfo(t *testing.T) {
Expand All @@ -461,6 +484,8 @@ func TestTaskListInfo(t *testing.T) {
assert.Equal(t, expected.LastUpdated.Sub(actual.LastUpdated), time.Duration(0))
assert.Equal(t, expected.ExpiryTimestamp.Sub(actual.ExpiryTimestamp), time.Duration(0))
assert.Equal(t, expected.AdaptivePartitionConfig, actual.AdaptivePartitionConfig)
assert.Nil(t, taskListInfoFromThrift(nil))
assert.Nil(t, taskListInfoToThrift(nil))
}

func TestTransferTaskInfo(t *testing.T) {
Expand All @@ -480,6 +505,8 @@ func TestTransferTaskInfo(t *testing.T) {
}
actual := transferTaskInfoFromThrift(transferTaskInfoToThrift(expected))
assert.Equal(t, expected, actual)
assert.Nil(t, transferTaskInfoFromThrift(nil))
assert.Nil(t, transferTaskInfoToThrift(nil))
}

func TestTimerTaskInfo(t *testing.T) {
Expand All @@ -495,6 +522,8 @@ func TestTimerTaskInfo(t *testing.T) {
}
actual := timerTaskInfoFromThrift(timerTaskInfoToThrift(expected))
assert.Equal(t, expected, actual)
assert.Nil(t, timerTaskInfoFromThrift(nil))
assert.Nil(t, timerTaskInfoToThrift(nil))
}

func TestReplicationTaskInfo(t *testing.T) {
Expand All @@ -514,4 +543,6 @@ func TestReplicationTaskInfo(t *testing.T) {
}
actual := replicationTaskInfoFromThrift(replicationTaskInfoToThrift(expected))
assert.Equal(t, expected, actual)
assert.Nil(t, replicationTaskInfoFromThrift(nil))
assert.Nil(t, replicationTaskInfoToThrift(nil))
}
Loading